This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 248542 - provide Fix-it for "non-virtual" hint
Summary: provide Fix-it for "non-virtual" hint
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Editor (show other bugs)
Version: 8.1
Hardware: All All
: P3 normal (vote)
Assignee: Alexander Simon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-10 12:55 UTC by Vladimir Voskresensky
Modified: 2015-03-25 03:22 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2014-11-10 12:55:44 UTC 
extracted from
https://netbeans.org/bugzilla/show_bug.cgi?id=248320
3) Hint doesn't provide "add virtual" fix, but only opens hint's settings

When virtual is added to method in derived class, then most probably it's an "error" not to have it in base class.
Comment 1 Vladimir Voskresensky 2015-03-17 16:24:10 UTC 
in C++11 mode derived class method should be annotated with "override" as well
Comment 2 Alexander Simon 2015-03-20 09:44:05 UTC 
add virtual keyword, change set:
http://hg.netbeans.org/cnd-main/rev/c37adc23a3bd
Comment 3 Alexander Simon 2015-03-20 14:15:48 UTC 
implement "Missing Override Keyword" hint, change set:
http://hg.netbeans.org/cnd-main/rev/65be9b101efa
Comment 4 Quality Engineering 2015-03-25 03:22:39 UTC 
Integrated into 'main-silver', will be available in build *201503250001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c37adc23a3bd
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixing Bug #248542 provide Fix-it for "non-virtual" hint
- add virtual keyword