This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246492 - RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1
Summary: RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: RequireJS (show other bugs)
Version: 8.0.1
Hardware: PC Linux
: P1 normal (vote)
Assignee: Petr Pisl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-16 12:30 UTC by Vladimir Riha
Modified: 2014-09-08 06:00 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
all logs from 8.0 to 8.0.1 upgrade (83.74 KB, application/zip)
2014-08-20 09:41 UTC, Vladimir Riha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2014-08-16 12:30:58 UTC
Extracted from issue 246476:

My steps were:
 - install 8.0 full distro with ergonomics (and with updates during installation)
 - create HTML5 and PHP projects
 - replace catalog link to NB distribution with the 8.0.1 staging link
 - install all updates

=> Some plugins (imho new in 8.0.1) have not been  installed during the update (they are offered in Available plugins after upgrade):
 - javascript2 requirejs (and these features are really missing in IDE)
 - javascript2 prototypejs

All logs from update/installation are here
https://netbeans.org/bugzilla/attachment.cgi?id=148715


This is a stopper for 8.0.1
Comment 1 Petr Pisl 2014-08-17 22:26:45 UTC
Attempt to fix this problem. http://hg.netbeans.org/web-main/rev/a447e7abdb25

I hope that it will help. Not sure how to test it, except to push the change to the releases and wait for next rc build.
Comment 2 Petr Pisl 2014-08-17 22:59:45 UTC
I was a little bit playing with it and it looks like this patch should help. Without the patch the modules are not installed at all and user has to install them separated. The new dependencies should push these new modules to the update as well. Can I integrated it to the releases?
Comment 3 Vladimir Riha 2014-08-18 06:57:06 UTC
Thanks for quick fix.

(In reply to Petr Pisl from comment #2)
> Can I integrated it to the releases?

I'm not sure, I wanted to create catalog and deploy all the modules to localhost server but I don't know how to build it :/ 

Mariane, Jirko, what do you think?
Comment 4 Jiri Kovalsky 2014-08-18 08:36:26 UTC
In my opinion we should clone the latest sources which include Petr's fix, build it and then use build-nbms and generate-uc-catalog target to build local update center. Then you can edit URL of the standard distribution to something like file://localhost/home/cesilko/sources/main-silver/nbbuild/catalog.xml

I am not sure it will work but worth trying... ;)
Comment 5 Vladimir Riha 2014-08-18 09:08:16 UTC
OK, thanks. Unfortunately the build-nbms failed with 

/home/vriha/Documents/repo/releases/nbbuild/templates/projectized.xml:123: Cannot compile against a module: /home/vriha/Documents/repo/releases/nbbuild/netbeans/ide/modules/org-netbeans-modules-javascript2-prototypejs.jar because of dependency: org.netbeans.modules.javascript2.prototypejs > 0.2 found 0.1.1


So I'll try to change version in javascript2.kit/nbproject/project.xml to 0.1.1. Petre please correct me if I'm wrong. Thanks
Comment 6 Vladimir Riha 2014-08-18 09:08:55 UTC
... and the same for RequireJS
Comment 7 Vladimir Riha 2014-08-18 10:30:12 UTC
So I did following: 
 - in release801 branch, applied the fix (with changed versions to 0.1.1)
 - build-nbms & generate-uc-catalog
 - installed 8.0 full distro with ergonomics (and with updates during installation)
 - created HTML5 and PHP projects
 - replaced catalog link to the one created by the generate-uc-catalog task
 - installed all updates

=> after restart, both RequireJS and PrototypeJS were installed.

I noticed (not sure if related), that in Plugins|Installed, I have only 4 groups: Java ME, User Installed Plugins, PHP, Base IDE. If I check "Show details", it seem to contain all modules as usually.

After the restart after installing updates, all features have been activated. As a result, IDE reported that new updates are available for features that were originally not activated by me. That means I have some modules updated to 8.0.1 and some at 8.0.
Comment 8 Vladimir Riha 2014-08-18 10:46:24 UTC
I don't think the mentioned issue is related to the fix. Making as verified, please transplant it to release801 but I guess with versions 0.1.1 as that's version of these modules in release801. Thanks
Comment 9 Petr Pisl 2014-08-18 12:39:13 UTC
The changes are done on releases branch.
Comment 10 Quality Engineering 2014-08-20 02:18:00 UTC
Integrated into 'releases/release801', will be available in build *201408192300* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/dd50f56e719e
User: Petr Pisl <ppisl@netbeans.org>
Log: #246492 - RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1
Comment 11 Quality Engineering 2014-08-20 02:21:03 UTC
Integrated into 'main-silver', will be available in build *201408200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a447e7abdb25
User: Petr Pisl <ppisl@netbeans.org>
Log: #246492 - RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1
Comment 12 Vladimir Riha 2014-08-20 09:40:34 UTC
I'm sorry but it still does not at least in one case:
 - start NB 8.0 (WITHOUT patch2)
 - activate HTML5 and PHP
 - upgrade to 8.0.1

=> RequireJS and PrototypeJS are not installed and it breaks current IDE installation.

It seems like in catalog, javascript2.kit has dependencies

 org.netbeans.modules.javascript2.prototypejs > 0.1.1, org.netbeans.modules.javascript2.requirejs > 0.1.1" 


but these modules are in version 0.1.1 so they are not downloaded/installed while latest javascript2.kit is downloaded, probably because editor.kit has dependency on org.netbeans.modules.javascript2.kit, I'm not sure

The error window opened by IDE when restarting after upgrade contains:

Warning - could not install some modules: JavaScript2 Kit - The module named org.netbeans.modules.javascript2.prototypejs was needed and not found. JavaScript2 Kit - The module named org.netbeans.modules.javascript2.requirejs was needed and not found. 16 further modules could not be installed due to the above problems.
Comment 13 Vladimir Riha 2014-08-20 09:41:48 UTC
Created attachment 148781 [details]
all logs from 8.0 to 8.0.1 upgrade
Comment 14 Petr Pisl 2014-08-20 09:43:34 UTC
Ok, I will change the version.
Comment 15 Vladimir Riha 2014-08-20 10:03:04 UTC
Thank you, I'm not sure why it worked for me with custom made catalog...

In case I have 8.0 Patch2 -> 8.0.1, IDE does not download these 2 modules during update, but it is at least capable of running/starting.
Comment 16 Petr Pisl 2014-08-20 11:58:57 UTC
I played with this and the version are IMHO ok. I have try this: http://hg.netbeans.org/web-main/rev/70b85c3da237 , but I'm not sure, whether it helps. Can I push this to releases?
Comment 17 Petr Pisl 2014-08-20 12:18:27 UTC
The last change is also in releases now.
Comment 18 Vladimir Riha 2014-08-20 12:40:12 UTC
I tried following with JDK7u65:

Case 1
========
- install NetBeans 8.0 + patch 2 
- create HTML5 and PHP projects
- upgrade to 8.0.1
=> all went OK, both modules were installed


Case 2
========
- install NB 8.0 (without patch)
- create HTML5 and PHP projects
- upgrade to 8.0.1
=> IDE has started OK, but the 2 plugins are not installed


I'll try the same with stable JDK8u11
Comment 19 Vladimir Riha 2014-08-20 13:29:59 UTC
With JDK8u11, both Case 1 and Case 2 went OK. I tried again Case 2 with JDK7u65 and this time it went OK as well....

I guess it could be random or just very nondeterministic or the network could be blamed. I really don't know
Comment 20 Petr Pisl 2014-08-20 13:43:02 UTC
So can we close the issue as fixed?
Comment 21 Vladimir Riha 2014-08-20 14:31:53 UTC
I've tried both mentioned cases on JDK8u11, JDK7u65, JDK8u20 ea and all six attempts went OK, plugins were installed each time. So I guess yes, it is fixed. Thank you
Comment 22 Jiri Kovalsky 2014-08-20 14:45:49 UTC
Works for me too.

Product Version: NetBeans IDE 8.0.1 (Build 201408142300)
Updates: Updates available
Java: 1.8.0_20; Java HotSpot(TM) 64-Bit Server VM 25.20-b23
Runtime: Java(TM) SE Runtime Environment 1.8.0_20-b31
System: Linux version 3.13.0-24-generic running on amd64; UTF-8; en_US (nb)
Comment 23 Quality Engineering 2014-08-21 02:19:47 UTC
Integrated into 'releases/release801', will be available in build *201408202300* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/f476637b59eb
User: Petr Pisl <ppisl@netbeans.org>
Log: #246492 - RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1
Comment 24 Quality Engineering 2014-08-21 02:29:59 UTC
Integrated into 'main-silver', will be available in build *201408210001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/70b85c3da237
User: Petr Pisl <ppisl@netbeans.org>
Log: #246492 - RequireJS and PrototypeJS plugins not installed when upgrading from 8.0 to 8.0.1