This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246345 - GlassFish version changed from 4.0.1 to 4.1
Summary: GlassFish version changed from 4.0.1 to 4.1
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 8.0.1
Hardware: PC Windows 7
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-08 10:21 UTC by Libor Fischmeistr
Modified: 2014-08-14 11:51 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
gf4.1 (142.32 KB, image/png)
2014-08-08 10:21 UTC, Libor Fischmeistr
Details
sdk patch (2.02 KB, patch)
2014-08-08 15:18 UTC, Petr Hejl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Libor Fischmeistr 2014-08-08 10:21:16 UTC
Created attachment 148601 [details]
gf4.1

GlassFish version number has been changed from 4.0.1 to 4.1 GlassFish plugin should reflect it.

There is GF 4 in Servers node, but actually it's 4.1. See screenshot.
Comment 1 Petr Hejl 2014-08-08 15:16:38 UTC
Hopefully should be fixed in web-main 275f44824475. Please verify.

Unfortunately one has to adapt the code with every GF release. Plugin is very strict about that. Now it is possible to register GF 4.1 and there is 4.1 in GF registered by installer. I checked all different places where checking against server version is done and I believe the plugin should work. Needs more testing though.

I wasn't brave enough the update the whole gf-tooling-sdk, so I updated only the necessary classes. I'll attach the patch.
Comment 2 Petr Hejl 2014-08-08 15:18:51 UTC
Created attachment 148608 [details]
sdk patch
Comment 3 Petr Hejl 2014-08-08 15:20:22 UTC
One more thing. Once released the GF must be made available here: http://download.java.net/glassfish/4.1/release/glassfish-4.1-ml.zip
Comment 4 Petr Hejl 2014-08-08 15:38:30 UTC
Let me know once (if) this should be transplanted to release801.
Comment 5 Antonin Nebuzelsky 2014-08-08 15:46:01 UTC
Let's set TM=8.0.1 when backported. The backport must be done early next week.

Included QE for the verification.

Thanks.
Comment 6 Libor Fischmeistr 2014-08-08 15:57:39 UTC
(In reply to Petr Hejl from comment #3)
> One more thing. Once released the GF must be made available here:
> http://download.java.net/glassfish/4.1/release/glassfish-4.1-ml.zip

I think this link should be changed to http://download.java.net/glassfish/4.1/release/glassfish-4.1.zip because, ML packages are no more available since 4.1.

And till the GF is not released, the link cannot be reachable. Look at the http://dlc.sun.com.edgesuite.net/glassfish/4.1/ structure...
Comment 7 Stepan Zebra 2014-08-08 16:29:26 UTC
I'll take care of the verification ASAP.

Can the download location of 4.1 release be guaranteed now?
Comment 8 Petr Hejl 2014-08-08 16:38:31 UTC
(In reply to Libor Fischmeistr from comment #6)
> (In reply to Petr Hejl from comment #3)
> > One more thing. Once released the GF must be made available here:
> > http://download.java.net/glassfish/4.1/release/glassfish-4.1-ml.zip
> 
> I think this link should be changed to
> http://download.java.net/glassfish/4.1/release/glassfish-4.1.zip because, ML
> packages are no more available since 4.1.
Fixed in web-main 1f7f0b17b978.
Comment 9 Petr Hejl 2014-08-08 21:13:15 UTC
Fixing failed build - web-main 07ab50dcc66a.
Comment 10 Quality Engineering 2014-08-10 01:51:06 UTC
Integrated into 'main-silver', will be available in build *201408100001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/275f44824475
User: Petr Hejl <phejl@netbeans.org>
Log: #246345 - GlassFish version changed from 4.0.1 to 4.1
Comment 11 Stepan Zebra 2014-08-10 22:04:14 UTC
verified in trunk (with exception of the server download), no problems found
Comment 12 Petr Hejl 2014-08-11 08:54:43 UTC
Martine, please review the patch. Thanks.
Comment 13 Martin Fousek 2014-08-11 08:59:07 UTC
The patch seems to be ok.
Comment 14 Petr Hejl 2014-08-11 09:13:02 UTC
Transplanted to release801 as 14c56a897463, 96ad30776177 and 29742848e7eb.
Comment 15 Quality Engineering 2014-08-12 02:31:59 UTC
Integrated into 'main-silver', will be available in build *201408120001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/eeb783e79897
User: Petr Hejl <phejl@netbeans.org>
Log: #246345 - GlassFish version changed from 4.0.1 to 4.1
Comment 16 Quality Engineering 2014-08-13 02:10:54 UTC
Integrated into 'releases/release801', will be available in build *201408122300* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/14c56a897463
User: Petr Hejl <phejl@netbeans.org>
Log: #246345 - GlassFish version changed from 4.0.1 to 4.1
Comment 17 Stepan Zebra 2014-08-14 11:51:53 UTC
verified in 8.0.1

verification of the download will be done after the location goes live in issue 246455

Product Version: NetBeans IDE 8.0.1 RC1 (Build 201408122300)
Java: 1.8.0_11; Java HotSpot(TM) 64-Bit Server VM 25.11-b03
Runtime: Java(TM) SE Runtime Environment 1.8.0_11-b12
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)