This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 245995 - Fix references adds absolute paths into private properties even if not needed
Summary: Fix references adds absolute paths into private properties even if not needed
Status: VERIFIED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant (show other bugs)
Version: 8.0.1
Hardware: All All
: P2 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords:
Depends on:
Blocks: 245979
  Show dependency tree
 
Reported: 2014-07-25 11:56 UTC by Tomas Mysik
Modified: 2014-08-08 11:16 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed fix (1.34 KB, patch)
2014-07-25 11:56 UTC, Tomas Mysik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2014-07-25 11:56:45 UTC
Created attachment 148312 [details]
proposed fix

Found when investigating issue #245979. The problem is that ReferenceHelper.fixReferences() adds absolute paths into private properties even if it is not needed - this is IMHO wrong.

Attaching proposed fix, the full path is added into private.properties _only_ if it is already there. I just verified that it solves issue #245979 (and does not break any test in your module :).

Marking as P2 since issue #245979.

I hope that I am not wrong, thanks.
Comment 1 Tomas Mysik 2014-07-30 09:22:49 UTC
After discussion with TomasZ, reassigning to him. Thanks!
Comment 2 Tomas Zezula 2014-08-04 15:46:56 UTC
Fixed jet-main dd930fb69391
Comment 3 Tomas Zezula 2014-08-04 16:08:06 UTC
Transplanted into release801: 6520adc555a9
Comment 4 Quality Engineering 2014-08-06 02:38:24 UTC
Integrated into 'main-silver', will be available in build *201408060001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/dd930fb69391
User: Tomas Zezula <tzezula@netbeans.org>
Log: #245995:Fix references adds absolute paths into private properties even if not needed
Comment 5 Vladimir Riha 2014-08-07 09:02:29 UTC
Issue 245979 is now working fine, thanks

Product Version: NetBeans IDE Dev (Build 201408070001)
Java: 1.8.0_11; Java HotSpot(TM) Client VM 25.11-b03
Runtime: Java(TM) SE Runtime Environment 1.8.0_11-b12
System: Linux version 3.13.0-32-generic running on i386; UTF-8; en_US (nb)
Comment 6 Quality Engineering 2014-08-07 14:46:53 UTC
Integrated into 'releases/release801', will be available in build *201408071314* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/6520adc555a9
User: Tomas Zezula <tzezula@netbeans.org>
Log: #245995:Fix references adds absolute paths into private properties even if not needed
Comment 7 Vladimir Riha 2014-08-08 11:16:41 UTC
Verified in 8.0.1 based on the 245979


Product Version: NetBeans IDE 8.0.1 RC1 (Build 201408072300)
Java: 1.8.0_11; Java HotSpot(TM) Client VM 25.11-b03
Runtime: Java(TM) SE Runtime Environment 1.8.0_11-b12
System: Linux version 3.13.0-32-generic running on i386; UTF-8; en_US (nb)