This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 244856 - Breakpoints in JavaScript don't seem to stop execution on JDK8_u20
Summary: Breakpoints in JavaScript don't seem to stop execution on JDK8_u20
Status: VERIFIED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 8.0
Hardware: PC Linux
: P1 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2014-06-03 09:27 UTC by Jaroslav Tulach
Modified: 2014-07-07 14:40 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2014-06-03 09:27:21 UTC
I was just testing recent patches in nashorn and it seems the breakpoints integration is broken. What I did:

$ hg clone http://hg.openjdk.java.net/jdk8u/jdk8u-dev
$ cd jdk8u-dev
$ . get_source.sh
$ cd nashorn
$ hg up -C 3f7d86480ce5
$ cd make
$ ant clean jar

and then I copied the created nashorn.jar into my existing JDK8_u5. When I try to hit a breakpoint in an avatar.js source (but probably any JavaScript source), it is not hit at all. JDK8_u5 works without problems.
Comment 1 Jaroslav Tulach 2014-06-03 09:30:18 UTC
Following fixes the problem, so this really seems to be regression:

$ cd nashorn/make
$ hg up -C jdk8-b12
$ ant clean jar
Comment 2 Martin Entlicher 2014-06-03 12:20:25 UTC
I can confirm that this is reproducible with build http://www.java.net/download/jdk8u20/archive/b16/binaries/jdk-8u20-ea-bin-b16-linux-x64-28_may_2014.tar.gz
Comment 3 Martin Entlicher 2014-06-03 14:20:48 UTC
jdk.nashorn.internal.runtime.Source has changed.
It contained fields:
name
base
content
length
hash
url

Now in contains fields:
name
base
data
hash
digest

Caused by http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/cdf42b4b8226
Comment 4 Martin Entlicher 2014-06-03 15:06:34 UTC
Fixed by changeset:   274751:37a806f20c38
http://hg.netbeans.org/core-main/rev/37a806f20c38
Comment 5 Quality Engineering 2014-06-04 02:14:50 UTC
Integrated into 'main-silver', will be available in build *201406040001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/37a806f20c38
User: mentlicher@netbeans.org
Log: #244856: Use the new Source.data field when content and url are not available.
Comment 6 Jiri Kovalsky 2014-06-10 14:07:22 UTC
Let's fix this in 8.0 Patch 2. Martine, please integrate this fix into releases/release80 branch. Thanks.
Comment 7 Martin Entlicher 2014-06-10 16:48:29 UTC
To prevent from breaking the debugger contract in the future, issue https://bugs.openjdk.java.net/browse/JDK-8044798 was submitted.
This change adapts Nashorn debugger for the new APIs:
changeset:   274870:ebf692bceae1
http://hg.netbeans.org/core-main/rev/ebf692bceae1
Comment 9 Jiri Kovalsky 2014-06-11 16:05:50 UTC
The fix works fine in today's daily build of 8.0 #201406111322 with JDK 1.8.0_20-ea; Java HotSpot(TM) 64-Bit Server VM 25.20-b16. Thanks!
Comment 10 Quality Engineering 2014-06-12 06:39:54 UTC
Integrated into 'main-silver', will be available in build *201406120533* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/ebf692bceae1
User: mentlicher@netbeans.org
Log: #244856: Adapting for changes to be introduced by the fix of JDK issue JDK-8044798. A stable debugging APIs for source retrieval and script invocation is introduced.
Comment 11 Jiri Kovalsky 2014-06-12 13:12:00 UTC
Verified in 8.0 > 8.0 Patch 2, 8.0 Patch 1.1 > 8.0 Patch 2 and 8.0 > 8.0 Patch 1.0 > 8.0 Patch 2.

Product Version: NetBeans IDE 8.0 (Build 201403101706)
Updates: NetBeans IDE is updated to version NetBeans 8.0 Patch 2
Java: 1.8.0_20-ea; Java HotSpot(TM) 64-Bit Server VM 25.20-b16
Runtime: Java(TM) SE Runtime Environment 1.8.0_20-ea-b16
System: Linux version 3.13.0-24-generic running on amd64; UTF-8; en_US (nb)
User directory: /home/cesilko/.netbeans/8.0
Cache directory: /home/cesilko/.cache/netbeans/8.0
Comment 12 Quality Engineering 2014-07-07 14:40:40 UTC
Integrated into 'releases/release80', will be available in build *201407071338* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/1dc81027957b
User: mentlicher@netbeans.org
Log: #244856: Use the new Source.data field when content and url are not available.
(transplanted from 37a806f20c38c94ad92ac8267ebf9282b8857099)