This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 244795 - Do not require node modules folder
Summary: Do not require node modules folder
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Tools (show other bugs)
Version: 8.0.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Jan Becicka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-29 14:56 UTC by Vladimir Riha
Modified: 2014-07-04 06:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2014-05-29 14:56:39 UTC
In Dev build, it seems like if project contains package.json, IDE needs node modules folder and if missing, marks project as "broken". 

I think this shouldn't happen
  - just because project has package.json, doesn't mean it has any dependencies (no dependencies => no node_modules folder). 
  - if you e.g. create new HTML5 project from online template AngularJS Seed or AngularJS Phone Catalog (HTML5 sample project), they are marked as broken
  - dependencies can be installed globally in "any" folder outside of project 

Maybe just bubble notification like "You might want to run npm install" should be enough. It would open just once on project creation or first project open.


Product Version: NetBeans IDE Dev (Build 201405290001)
Java: 1.8.0_05; Java HotSpot(TM) Client VM 25.5-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_05-b13
System: Linux version 3.2.0-60-generic-pae running on i386; UTF-8; en_US (nb)
Comment 1 Vladimir Riha 2014-05-29 15:16:50 UTC
I noticed if I run NPM install from IDE, the warning about missing node modules folder doesn't go away. Bubble notification would "solve" this as well :)
Comment 2 Jan Becicka 2014-07-02 14:36:03 UTC
Changeset: b5738bfa48ec
Author:    Jan Becicka <jbecicka@netbeans.org>
Date:      2014-07-02 16:35
Message:
Comment 3 Quality Engineering 2014-07-04 02:38:03 UTC
Integrated into 'main-silver', will be available in build *201407040001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/b5738bfa48ec
User: Jan Becicka <jbecicka@netbeans.org>
Log: Issue #244795 - Do not require node modules folder
Comment 4 Vladimir Riha 2014-07-04 06:55:46 UTC
Thank you, #1 is fixed and #2 makes sense that they are marked as "broken" because they really :)



Product Version: NetBeans IDE Dev (Build 201407040001)
Java: 1.8.0_05; Java HotSpot(TM) Client VM 25.5-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_05-b13
System: Linux version 3.13.0-29-generic running on i386; UTF-8; en_US (nb)