This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 243042 - Remove dependency of mimelookup implementation module on datasystems
Summary: Remove dependency of mimelookup implementation module on datasystems
Status: RESOLVED WONTFIX
Alias: None
Product: editor
Classification: Unclassified
Component: Settings (show other bugs)
Version: 8.0
Hardware: PC Linux
: P3 normal (vote)
Assignee: Miloslav Metelka
URL:
Keywords:
: 243099 243288 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-19 09:55 UTC by Miloslav Metelka
Modified: 2016-07-07 07:29 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2014-03-19 09:55:59 UTC 
The dependency is only due to instantiation through DataObject and InstanceCookie which can be solved in another way.
Comment 1 Miloslav Metelka 2014-03-19 09:57:52 UTC 
http://hg.netbeans.org/jet-main/rev/b4e9ae6e638d
Comment 2 Quality Engineering 2014-03-20 03:05:58 UTC 
Integrated into 'main-silver', will be available in build *201403200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/b4e9ae6e638d
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #243042 - Remove dependency of mimelookup implementation module on datasystems.
Comment 3 Miloslav Metelka 2014-03-20 14:40:04 UTC 
I've made a rollback of b4e9ae6e638d since it causes a regression in Parsing API indexers. I've already tracked the problem but I do not have a final solution yet so until then I restored the original state.

http://hg.netbeans.org/jet-main/rev/02555f509844
Comment 4 Miloslav Metelka 2014-03-20 14:54:13 UTC 
If I put a debug into IndexerCache.Tracker.getLookupData() e.g.

                System.err.println("LOOKUP RESULT for mimeType=" + mimeType + ": " + r.allClasses());

(or po allInstances() the resulting classes differ. For example indexers for twig mime type get retrieved in patched setup while they do not in the original setup.
Comment 5 Svata Dedic 2014-03-21 08:08:45 UTC 
Please also note the issue #243099; it might be caused by MIME lookup fiddling as well - not reproducible on a fresh checkout, neither on 8.0 release.
Comment 6 Quality Engineering 2014-03-23 02:29:18 UTC 
Integrated into 'main-silver', will be available in build *201403230001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/02555f509844
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #243042 - Rollback of b4e9ae6e638d since it causes a regression in Parsing API indexers.
Comment 7 Vladimir Voskresensky 2014-03-24 06:22:31 UTC 
Most probably it was also the reason for regression in issue #243174. Please, check C++ files as well.

Thanks
Comment 8 Svata Dedic 2014-03-28 08:03:11 UTC 
*** Bug 243099 has been marked as a duplicate of this bug. ***
Comment 9 Svata Dedic 2014-03-28 08:03:42 UTC 
*** Bug 243288 has been marked as a duplicate of this bug. ***
Comment 10 Miloslav Metelka 2014-04-01 09:30:02 UTC 
Finally found a proper solution - for now it's only intergrated in server_split branch to not destabilize trunk:
http://hg.netbeans.org/jet-main/rev/020feda3f37a
Comment 11 Quality Engineering 2014-10-18 05:13:16 UTC 
Integrated into 'main-silver', will be available in build *201410180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/020feda3f37a
User: Miloslav Metelka <mmetelka@netbeans.org>
Log: #243042 - Remove dependency of mimelookup implementation module on datasystems - fixed problem with diverging instances of classes for an empty mime-type in non-empty mime-type lookups.
Comment 12 Martin Balin 2016-07-07 07:29:59 UTC 
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss