This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 242311 - Test Results window shows test class skipped when there are also failed tests
Summary: Test Results window shows test class skipped when there are also failed tests
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: JUnit (show other bugs)
Version: 7.4
Hardware: All All
: P1 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords: 8.0_HR_FIX
Depends on:
Blocks:
 
Reported: 2014-02-25 09:04 UTC by attila.kelemen
Modified: 2014-03-04 08:04 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description attila.kelemen 2014-02-25 09:04:25 UTC
When there are skipped tests the test class node (suite in the API) will always be marked as skipped except when tests were aborted. This seems to me rather unexpected because knowing that there are failures is more important. Actually, I would say, that having skipped tests should only be a side note even to passed (but this is less of a problem).
Comment 1 _ rkubacki 2014-03-01 22:06:47 UTC
I see even worse case of results handling:
I run a test file and there are some passing and some ignored tests (Tests run: 30, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 29.775 sec) and the test class is shown as yellow triangle (warning?) with indecipherable badge and label contains text ABORTED. 

1. skipping/ignoring some tests is perfectly OK and those skipped tests should not affect basic red/green status.

2. why was my test run marked as aborted is another complete mystery
Comment 2 Theofanis Oikonomou 2014-03-03 11:11:57 UTC
(In reply to _ rkubacki from comment #1)
> I see even worse case of results handling:
> I run a test file and there are some passing and some ignored tests (Tests
> run: 30, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 29.775 sec) and
> the test class is shown as yellow triangle (warning?) with indecipherable
> badge and label contains text ABORTED. 
> 
> 1. skipping/ignoring some tests is perfectly OK and those skipped tests
> should not affect basic red/green status.
> 
> 2. why was my test run marked as aborted is another complete mystery

There were issues in 7.4 with updating the status of the project/testcase status and/or creating the actual nodes. This should be fixed now as this is done asynchronously, fixed in http://hg.netbeans.org/core-main/rev/b9d585b24a9b, so I guess it will take care of the indecipherable badge and label contents.

I also agree that errors/failures are more important than skipped tests so will fix this asap.
Comment 3 Theofanis Oikonomou 2014-03-03 11:14:05 UTC
Changeset: 876539d8b52d
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-03-03 12:15
Message:
Comment 4 Marian Mirilovic 2014-03-03 12:30:06 UTC
Jirka K., what do you think ?
Comment 5 Jiri Kovalsky 2014-03-03 14:27:29 UTC
I agree this should be fixed in 8.0. Unfortunately, internal Hudson does not have any build with the fix. Fanis, where can I verify the fix?
Comment 6 Theofanis Oikonomou 2014-03-03 14:39:30 UTC
(In reply to Jiri Kovalsky from comment #5)
> I agree this should be fixed in 8.0. Unfortunately, internal Hudson does not
> have any build with the fix. Fanis, where can I verify the fix?

the fix is in core-main and also transplanted to release80: http://hg.netbeans.org/releases/rev/0af97a0d6c69
Comment 7 Quality Engineering 2014-03-04 00:56:41 UTC
Integrated into 'releases/release80', will be available in build *201403032200* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/0af97a0d6c69
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #242311 - Test Results window shows test class skipped when there are also failed tests
(transplanted from 876539d8b52da012a498ec935f1df2ce2b894d3b)
Comment 8 Quality Engineering 2014-03-04 02:56:44 UTC
Integrated into 'main-silver', will be available in build *201403040001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/876539d8b52d
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #242311 - Test Results window shows test class skipped when there are also failed tests
Comment 9 Jiri Kovalsky 2014-03-04 08:04:16 UTC
Product Version: NetBeans IDE Dev (Build 201403040001)
Java: 1.8.0; Java HotSpot(TM) 64-Bit Server VM 25.0-b69
Runtime: Java(TM) SE Runtime Environment 1.8.0-b129
System: Linux version 3.0.0-12-generic running on amd64; UTF-8; cs_CZ (nb)
User directory: /home/cesilko/.netbeans/dev
Cache directory: /home/cesilko/.cache/netbeans/dev

Verified in the latest development build.