This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 240879 - Inconsistent activation/deactivation of Apply button from Editor->On Save->Java options panel
Summary: Inconsistent activation/deactivation of Apply button from Editor->On Save->Ja...
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Options&Settings (show other bugs)
Version: 8.0
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords:
Depends on:
Blocks: 239792
  Show dependency tree
 
Reported: 2014-01-23 12:18 UTC by Theofanis Oikonomou
Modified: 2014-01-24 02:39 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch (11.51 KB, patch)
2014-01-23 12:28 UTC, Theofanis Oikonomou
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Theofanis Oikonomou 2014-01-23 12:18:22 UTC
The problem is that currently there is no way to access the saved value of any custom customizer like the one present in Java language.
Comment 1 Theofanis Oikonomou 2014-01-23 12:28:25 UTC
Created attachment 144292 [details]
patch

The patch creates a new class in PreferencesCustomizer named CustomCustomizer. It does not brake any existing client. The same idea will be applied in two more editor panels, Code completion and Hints if this change will be accepted. I also included how the new api will be used by existing, or new for that matter, clients.
Comment 2 Theofanis Oikonomou 2014-01-23 12:33:03 UTC
Milutin, I do not think a fast api review for this change is needed, since options.editor only exposes api/spi to friend modules. No client is broken. Only clients that provide a custom customizer will be affected in the sense that they will need to extend CustomCustomizer and register it in the xml layer. If on the other hand you think this deserves a review just let me know and I will start one. Thank you
Comment 3 Milutin Kristofic 2014-01-23 13:14:20 UTC
I am ok with that.
Comment 4 Theofanis Oikonomou 2014-01-23 14:39:43 UTC
(In reply to Milutin Kristofic from comment #3)
> I am ok with that.

In that case I will push the fix for OnSave->Java panel today and will fix the code completion and hints panels that need to be modified to register the new CustomCustomizer in the following days. Thank you
Comment 5 Theofanis Oikonomou 2014-01-23 14:46:52 UTC
Changeset: 20768a155a47
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-01-23 15:46
Message:
Comment 6 Quality Engineering 2014-01-24 02:39:24 UTC
Integrated into 'main-silver', will be available in build *201401240001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/20768a155a47
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #240879 - Inconsistent activation/deactivation of Apply button from Editor->On Save->Java options panel