This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 240737 - Validation of all PHP IDE Options broken
Summary: Validation of all PHP IDE Options broken
Status: RESOLVED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Code (show other bugs)
Version: 8.0
Hardware: All All
: P2 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2014-01-21 09:46 UTC by Tomas Mysik
Modified: 2014-01-23 02:40 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2014-01-21 09:46:54 UTC 
After your last changes, the validation of PHP IDE Options does not work properly.

Steps:
- open IDE Options > PHP > General
- PHP 5 Interpreter is a valid file, no warning anywhere
- change it to some non-existing file e.g. "/tmp/a125d"
- warning appears
- return it back to its original value
-> the warning is still there but should not be since the file is valid again

This issue applies to _all_ PHP IDE Options panels so please, fix them all (in all PHP modules).

Thanks.

Product Version: NetBeans IDE Dev (Build 20140121-bd6d5ec3e03c)
Java: 1.7.0_51; Java HotSpot(TM) 64-Bit Server VM 24.51-b03
Runtime: Java(TM) SE Runtime Environment 1.7.0_51-b13
System: Linux version 3.11.0-15-generic running on amd64; UTF-8; cs_CZ (nb)
Comment 1 Theofanis Oikonomou 2014-01-21 18:20:47 UTC 
Changeset: 1ec780b0b71c
Author:    Theofanis Oikonomou <theofanis@netbeans.org>
Date:      2014-01-21 19:20
Message:
Comment 2 Theofanis Oikonomou 2014-01-21 18:23:42 UTC 
This is indeed a regression due to the latest changes regarding Apply button. The bug was caused because when isChanged() returned false, isValid() was not called on the controller, having as result to not clear the error/warning. Now I think that it works as expected. Thank you for catching this.
Comment 3 Quality Engineering 2014-01-23 02:40:22 UTC 
Integrated into 'main-silver', will be available in build *201401230001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/1ec780b0b71c
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Task #240737 - Validation of all PHP IDE Options broken