This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 239906 - Navigator Window ignores filterable/sortable configuration of StructureScanner
Summary: Navigator Window ignores filterable/sortable configuration of StructureScanner
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords: PATCH_AVAILABLE
Depends on: 239907
Blocks:
  Show dependency tree
 
Reported: 2014-01-01 23:29 UTC by matthias42
Modified: 2014-02-02 19:33 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot of the Problem (47.35 KB, image/png)
2014-01-01 23:29 UTC, matthias42
Details
proposed patch v1 (5.83 KB, patch)
2014-01-01 23:30 UTC, matthias42
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description matthias42 2014-01-01 23:29:53 UTC
Created attachment 143552 [details]
Screenshot of the Problem

I implemented language support for the property list ascii format and while doing so, I also implemented a structure scanner.

While the navigator window works, I also noticed, that my configuration (enabled sorting, disabled filtering) was ignored):

public class PListStructureScanner implements StructureScanner {
[...]
    @Override
    public Configuration getConfiguration() {
        return new Configuration(true, false);
    }
[...]
}

I had a look at the CSL Sourcecode and the problem lies in the fact, whether the filter menu and actions are created is dermined in the constructor, which is invoked with null as language and this leads to the default creation with the filter panel and actions.

I moved that functionality out of the constructor (for compatibility reasons it is still called there) and added it to the case when the navigator is refreshed for a exchanged fileObject.
Comment 1 matthias42 2014-01-01 23:30:27 UTC
Created attachment 143553 [details]
proposed patch v1
Comment 2 Milutin Kristofic 2014-01-30 15:36:25 UTC
Good insight, thank you. I pushed your patch to repository http://hg.netbeans.org/jet-main/rev/c313fda86661
Comment 3 Quality Engineering 2014-02-01 05:46:45 UTC
Integrated into 'main-silver', will be available in build *201402010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/48dc63649ec0
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #239906 - Navigator Window ignores filterable/sortable configuration of StructureScanner