This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 239013 - JSF facetlets closing tag is not crrectly
Summary: JSF facetlets closing tag is not crrectly
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSF Editor (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Martin Fousek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-01 04:44 UTC by hantsy
Modified: 2014-02-03 13:25 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
error (4.58 KB, image/png)
2013-12-01 04:44 UTC, hantsy
Details
screenshot from trunk build (100.27 KB, image/png)
2013-12-02 06:33 UTC, Martin Fousek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hantsy 2013-12-01 04:44:31 UTC
Created attachment 142755 [details]
error

All code completion are lower case, it is incorrect. I do not encounter this problem in NetBeans 7.3.
Comment 1 Martin Fousek 2013-12-02 06:33:10 UTC
Sorry, but I'm unable to reproduce your issue, I'm going to attach screenshot from my trunk build where it works well. Please could you specify which version of NetBeans IDE and the JSF jar do you use? Thanks a lot.
Comment 2 Martin Fousek 2013-12-02 06:33:43 UTC
Created attachment 142772 [details]
screenshot from trunk build

Promised screenshot that it works well to me.
Comment 3 hantsy 2013-12-02 08:57:46 UTC
NetBeans 7.4 Patch1
Oracle JDK 7 update 45
Windows 7 SP1

Java EE 7/JSF 2.2

I used a Maven based project.

<dependency>
                <groupId>javax</groupId>
                <artifactId>javaee-api</artifactId>
                <version>7.0</version>
                <scope>provided</scope>
            </dependency>


The code is hosted on my github.com, https://github.com/hantsy 

https://github.com/hantsy/ee7-sandbox/blob/master/pom.xml
Comment 4 Martin Fousek 2013-12-02 13:51:29 UTC
Sorry I'm still not able to reproduce the issue with the equivalent environment:
NetBeans 7.4 patch1, jdk 1.7.0_45, your project ee7-sandbox/jsf/flow-registration

CCing vriha, Vlado please could you try to reproduce that on your computer and let us know then? Thanks a lot.
Comment 5 Vladimir Riha 2013-12-02 16:02:03 UTC
It works for me as well


Product Version: NetBeans IDE 7.4 (Build 201310111528)
Updates: NetBeans IDE is updated to version NetBeans 7.4 Patch 1
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 6 Martin Fousek 2013-12-03 08:00:40 UTC
(In reply to Vladimir Riha from comment #5)
> It works for me as well

Thanks Vlado for trying that out.

Reported, we are not able to reproduce your issue. Please could you try out to reinstall you NetBeans 7.4 IDE or i.e. move your userdir and keep the NB7.4 recreate the userdir from the version 7.3. If you would be able fix that using the userdir change, feel free to attach packed UD here and I can take a look what could be wrong.

I'm afraid that without additional information I'm not able to help you here because we are not able to reproduce your troubles, sorry.
Comment 7 hantsy 2013-12-04 01:17:47 UTC
When I only used NetBeans 7.4 now, and used a zip archive instead of a installer, and I did not import settings from before version.

In ~/AppData/Local/NetBeans and ~/AppData/Roaming/NetBeans folders, only a 7.4 folder there.
Comment 8 hantsy 2013-12-04 15:20:24 UTC
In my Netbeans...

1. 
If I press CTRL+SPACE in this position, it works.

<h:selectManyCheckbox id="tags" value="#{editPostBean.post.tags}" >[CTRL+SPACE ]

2. if type after </, it will get the ERROR result in my picture.

<h:selectManyCheckbox id="tags" value="#{editPostBean.post.tags}" ></[CTRL+SPACE ]


And both cases, the Javadoc is incorrect, INCLUDING the result in your picture.
Comment 9 Martin Fousek 2013-12-04 15:38:14 UTC
(In reply to hantsy from comment #8)
> 1. If I press CTRL+SPACE in this position, it works.
> <h:selectManyCheckbox id="tags" value="#{editPostBean.post.tags}"
> >[CTRL+SPACE ]

We are going investigate it more what could be wrong and keep you informed. 

> 2. if type after </, it will get the ERROR result in my picture.
> <h:selectManyCheckbox id="tags" value="#{editPostBean.post.tags}"
> ></[CTRL+SPACE ]
> And both cases, the Javadoc is incorrect, INCLUDING the result in your
> picture.

You are right, the Javadoc window shows wrong item, reproducible. Thanks!
Comment 10 Vladimir Riha 2013-12-04 16:00:22 UTC
FYI I tried it on Windows, no luck reproducing


Product Version: NetBeans IDE Dev (Build 201312040002)
Java: 1.7.0_40; Java HotSpot(TM) 64-Bit Server VM 24.0-b55
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b40
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Comment 11 Martin Fousek 2013-12-09 09:55:20 UTC
Hantsy I debug pretty much the code around the completion. There is chance to get the completion lowercased in case that your file looks to be of HTML mimetype. Please could you send me first 10 rows of your facelet you are editing?

I tried ee7-sandbox/jsf/flow-registration/src/main/webapp/registration/registration.xhtml and it can't occur there since no doctype is found and the mimetype fallbacks to XHTML5 (due to xhtml mimetype of the file). Please attach your file "header". Thanks.
Comment 12 Martin Fousek 2013-12-09 10:30:59 UTC
The incorrect documentation fixed in web-main #0e459b6c241d. The completion item is created based on the unfinished tags, so the attribute is not known in such case and previous documentation was displayed. I'm hiding doc window for unknown tags now.
Comment 13 Quality Engineering 2013-12-10 02:44:50 UTC
Integrated into 'main-silver', will be available in build *201312100002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/0e459b6c241d
User: Martin Fousek <marfous@netbeans.org>
Log: #239013 - Documentation window for unknown elements is not shown
Comment 14 hantsy 2013-12-17 06:53:09 UTC
I have updated the netbeans IDE to 7.4 update 2, it is still there(the closing tag displays as low case).

I tried in the edit.xhtml(it includes HTML 5 doctype delcaration) in the jpa/converter project.
Comment 15 Martin Fousek 2014-02-03 13:25:07 UTC
(In reply to hantsy from comment #14)
> I tried in the edit.xhtml(it includes HTML 5 doctype delcaration) in the
> jpa/converter project.

I took a look into your jpa/converter:edit.html file. The ending tag is completed according to the HTML version. In your case it's recognized as HTML5 since you don't define that you are using XML namespace (xmlns="http://www.w3.org/1999/xhtml"). Once you will define the XML namespace the completion entries are not lowercased any more. I look around the HTML5 and Facelets and the correct notation looks to be really:
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
....

This part of the issue is wontfix. First part of the issue, incorrect documentation was fixed in web-main #0e459b6c241d so I'm closing this issue as fixed. Thanks for your report.