This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 237763 - Generation of / Completion for JSDoc does not work in embedded JS
Summary: Generation of / Completion for JSDoc does not work in embedded JS
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Martin Fousek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-29 14:19 UTC by Vladimir Riha
Modified: 2013-11-13 09:51 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2013-10-29 14:19:11 UTC
Having e.g. HTML file with following


  <body>
        <script>
            /**
            function somethindsg(num) {
            }

        </script>
        <div>TODO write content</div>
    </body>


Then if you press Enter after **, @param is not generated, if you type

             /**
             * @p
             */
            function somethindsg(num) {
            }


and invoke cc, nothing is offered



Product Version: NetBeans IDE Dev (Build 201310290001)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 1 Vladimir Riha 2013-11-01 10:20:37 UTC
Martine, could this go to patch? What do you think?
Comment 2 Martin Fousek 2013-11-01 10:27:20 UTC
(In reply to Vladimir Riha from comment #1)
> Martine, could this go to patch? What do you think?

I didn't give it attention yet. I'll fix the issue and let's speak about the inclusion into the patch if the patch will not be risky.
Comment 3 Martin Fousek 2013-11-04 07:16:19 UTC
(In reply to Martin Fousek from comment #2)
> (In reply to Vladimir Riha from comment #1)
> > Martine, could this go to patch? What do you think?
> 
> I didn't give it attention yet. I'll fix the issue and let's speak about the
> inclusion into the patch if the patch will not be risky.

It shouldn't be risky, I agree with marking this as a patch candidate.

Fixed in web-main #4aed9c60c379.
Comment 4 Vladimir Riha 2013-11-04 08:06:35 UTC
Thank you, marking as candidate then.
Comment 5 Vladimir Riha 2013-11-05 09:41:15 UTC
Thank you, verified in HTML and PHP files

Product Version: NetBeans IDE Dev (Build 201311050001)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 6 Martin Fousek 2013-11-08 13:05:16 UTC
Transplanted into release74 as:

changeset:   275305:7654c1e27cce
branch:      release74
summary:     #237763 - Generation of / Completion for JSDoc does not work in embedded JS

changeset:   275306:a9b60a0c62c7
branch:      release74
summary:     Increased spec. version, long description update
Comment 7 Quality Engineering 2013-11-11 20:12:09 UTC
Integrated into 'releases/release74', will be available in build *201311111738* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/7654c1e27cce
User: Martin Fousek <marfous@netbeans.org>
Log: #237763 - Generation of / Completion for JSDoc does not work in embedded JS
(transplanted from 4aed9c60c379e11c17a098d5753dc5025661423c)
Comment 8 Vladimir Riha 2013-11-13 08:42:25 UTC
JSDoc is generated properly, but mentioned code completion likely fixed by fixing issue 236731 which is unfortunately not in patch. Verified in patch

Product Version: NetBeans IDE 7.4 (Build 201311111738)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 9 Petr Pisl 2013-11-13 09:32:09 UTC
Vlado, so do you suggest to put issue #236731 into the patch?
Comment 10 Vladimir Riha 2013-11-13 09:51:57 UTC
Ideally it would be great but I'm not sure if it's not too late now. On the other hand I don't think JSDoc in embedded JS code is very common so the impact of this issue shouldn't be big.

Mariane, can we added issue 236731 to patch when it's after cut-off? It's already fixed and verified.