This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 237578 - Refactor rename for inline javascript stopped working in Netbeans 7.4
Summary: Refactor rename for inline javascript stopped working in Netbeans 7.4
Status: VERIFIED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.4
Hardware: PC Windows 7 x64
: P2 normal (vote)
Assignee: Petr Pisl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 18:07 UTC by eduramiba
Modified: 2013-11-15 08:42 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eduramiba 2013-10-23 18:07:34 UTC 
This only affects javascript code inside a <script> tag in an HTML file. It seems to work fine in a .js file.

In Netbeans 7.3 the rename (Ctrl + R) refactoring worked perfectly for both variables and functions but in Netbeans 7.4 this action gives the message "The Rename refactoring cannot be applied in this context."
Comment 1 Vladimir Riha 2013-10-29 11:01:03 UTC 
Thank you for reporting, reproducible
Comment 2 Vladimir Riha 2013-10-31 09:47:33 UTC 
Possible patch candidate?
Comment 3 Petr Pisl 2013-10-31 10:31:02 UTC 
Fixed in web-main:
http://hg.netbeans.org/web-main/rev/4d2a950c7713

I agree that this should go to the patch.
Comment 4 eduramiba 2013-11-01 18:36:11 UTC 
Thank you!
Comment 5 Vladimir Riha 2013-11-04 07:58:29 UTC 
Verifed

Product Version: NetBeans IDE Dev (Build 201311040001)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
Comment 6 Petr Pisl 2013-11-12 15:18:29 UTC 
The change was transplanted to the releases:
http://hg.netbeans.org/releases/rev/0f94f21c7ff1
Comment 7 Quality Engineering 2013-11-14 14:31:14 UTC 
Integrated into 'releases/release74', will be available in build *201311141216* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/0f94f21c7ff1
User: Petr Pisl <ppisl@netbeans.org>
Log: #237578 - Refactor rename for inline javascript stopped working in Netbeans 7.4
Comment 8 Vladimir Riha 2013-11-15 08:42:42 UTC 
Verified in patch


Product Version: NetBeans IDE 7.4 (Build 201311142201)
Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)