This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 236753 - defects in Introduce Variable
Summary: defects in Introduce Variable
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Completion (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Vladimir Voskresensky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 10:53 UTC by Vladimir Voskresensky
Modified: 2013-11-14 17:21 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2013-10-04 10:53:35 UTC
Comparing to Java we have following defects:
1) (important) after introduce variable is not in in-place rename mode => only declaration name is renamed, but replacement in expression is not changed

due to 1)
2) name collision should be better tracked (i.e. if there are local variable with to-be-introduced name => choose another name)

3) Replace All occurrences (small feature would need dialog, can be postponed)
Comment 1 Vladimir Voskresensky 2013-10-07 10:55:55 UTC
(In reply to Vladimir Voskresensky from comment #0)
> Comparing to Java we have following defects:
> 1) (important) after introduce variable is not in in-place rename mode =>
> only declaration name is renamed, but replacement in expression is not
> changed
fixed as changeset: 272276:5ea8457c8f1a
Comment 2 Quality Engineering 2013-10-11 02:23:00 UTC
Integrated into 'main-silver', will be available in build *201310110001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/011d2f4007b6
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: fixing #236753 - defects in Introduce Variable
- 1) (important) after introduce variable is not in in-place rename mode
(transplanted from 5ea8457c8f1abc413d2dd35d0d5d500e61907b8d)
Comment 3 Vladimir Voskresensky 2013-11-05 15:09:27 UTC
for the last on issue #236753 is added
Comment 4 Vladimir Voskresensky 2013-11-05 15:09:48 UTC
I meant issue #238008
Comment 5 Alexander Pepin 2013-11-14 17:21:16 UTC
verified in build 20131111