This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 236336 - Can't add custom goals with 'strange' characters to toolbar
Summary: Can't add custom goals with 'strange' characters to toolbar
Status: VERIFIED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 7.4
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milos Kleint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 17:54 UTC by Michel Graciano
Modified: 2013-11-22 08:51 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Graciano 2013-09-24 17:54:31 UTC
[ BUILD # : 7.4 RC1 ]
[ JDK VERSION : 1.7.0_21 ]

I have created a custom goal named 'Deploy on JBoss/Wildfly' and when I try to
add it to toolbar I have the following exception on IDE log file. Looks like
the problem happens when I use the character /. If I create a goal named only
'Deploy on JBoss', it works as expected.

SEVERE [org.openide.util.Exceptions]
org.openide.filesystems.FileStateInvalidException: File CUSTOM-Deploy on
JBoss/Wildfly.instance cannot be found in folder Actions/Maven.
	at
org.openide.filesystems.MultiFileObject.createData(MultiFileObject.java:1202)
	at org.openide.filesystems.FileUtil.copyFileImpl(FileUtil.java:569)
	at org.openide.filesystems.FileObject.copy(FileObject.java:154)
	at org.openide.filesystems.MultiFileObject.copy(MultiFileObject.java:1389)
	at org.openide.filesystems.MultiFileObject.copy(MultiFileObject.java:1389)
	at
org.netbeans.modules.maven.actions.RunCustomMavenAction.createActionDeclaration(
RunCustomMavenAction.java:177)
[catch] at
org.netbeans.modules.maven.customizer.ActionMappings.applyToolbarChanges(ActionM
appings.java:940)
	at
org.netbeans.modules.maven.options.SettingsPanel.btnGoalsActionPerformed(Setting
sPanel.java:693)
	at
org.netbeans.modules.maven.options.SettingsPanel.access$800(SettingsPanel.java:9
4)
	at
org.netbeans.modules.maven.options.SettingsPanel$5.actionPerformed(SettingsPanel
.java:397)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
	at
javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
	at
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.jav
a:252)
	at java.awt.Component.processMouseEvent(Component.java:6505)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3321)
	at java.awt.Component.processEvent(Component.java:6270)
	at java.awt.Container.processEvent(Container.java:2229)
	at java.awt.Component.dispatchEventImpl(Component.java:4861)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
	at java.awt.Container.dispatchEventImpl(Container.java:2273)
	at java.awt.Window.dispatchEventImpl(Window.java:2719)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:688)
	at java.awt.EventQueue$3.run(EventQueue.java:686)
	at java.security.AccessController.doPrivileged(Native Method)
	at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:7
6)
	at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:8
7)
	at java.awt.EventQueue$4.run(EventQueue.java:702)
	at java.awt.EventQueue$4.run(EventQueue.java:700)
	at java.security.AccessController.doPrivileged(Native Method)
	at
java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:7
6)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
	at
org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159)
	at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242
)
	at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150
)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)
Comment 1 Michel Graciano 2013-09-24 17:55:18 UTC
Maybe the Global Custom Goal UI should restrict the supported characters?
Comment 2 Milos Kleint 2013-10-01 08:37:50 UTC
http://hg.netbeans.org/core-main/rev/c925fc59809c
Comment 3 Tomas Danek 2013-11-04 14:24:23 UTC
Product Version: NetBeans IDE Dev (Build 201311040001)
Java: 1.7.0_45; Java HotSpot(TM) 64-Bit Server VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Mac OS X version 10.9 running on x86_64; UTF-8; en_US (nb)
User directory: /Users/tomas/Library/Application Support/NetBeans/dev
Cache directory: /Users/tomas/Library/Caches/NetBeans/dev

still not working properly:
- create custom goal "one/two", add button to toolbar
- invoke action from toolbar, nothing happens, and the reason is:
INFO [org.netbeans.modules.maven.ActionProviderImpl]: No handling for action: CUSTOM-onetwo. Ignoring.
Comment 4 Quality Engineering 2013-11-06 03:18:14 UTC
Integrated into 'main-silver', will be available in build *201311060001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e39caeeb2420
User: Milos Kleint <mkleint@netbeans.org>
Log: #236336 action name needs to stay the same, just the action path in layer fs should change
Comment 5 Tomas Danek 2013-11-12 10:57:00 UTC
verified in

Product Version: NetBeans IDE Dev (Build 201311120002)
Java: 1.7.0_45; Java HotSpot(TM) 64-Bit Server VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Mac OS X version 10.9 running on x86_64; UTF-8; en_US (nb)
User directory: /Users/tomas/Library/Application Support/NetBeans/dev
Cache directory: /Users/tomas/Library/Caches/NetBeans/dev
Comment 6 Milos Kleint 2013-11-13 12:13:20 UTC
http://hg.netbeans.org/releases/rev/0017b10772d0
Comment 7 Quality Engineering 2013-11-14 14:30:54 UTC
Integrated into 'releases/release74', will be available in build *201311141216* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/0017b10772d0
User: Milos Kleint <mkleint@netbeans.org>
Log: #236336 action name needs to stay the same, just the action path in layer fs should change
Comment 8 Tomas Danek 2013-11-22 08:51:53 UTC
verified in patch1

Product Version: NetBeans IDE 7.4 (Build 201310111528)
Updates: NetBeans IDE is updated to version NetBeans 7.4 Patch 1
Java: 1.7.0_45; Java HotSpot(TM) 64-Bit Server VM 24.45-b08
Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18
System: Mac OS X version 10.9 running on x86_64; UTF-8; en_US (nb)
User directory: /Users/tomas/Library/Application Support/NetBeans/7.4
Cache directory: /Users/tomas/Library/Caches/NetBeans/7.4