This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 234127 - java.lang.NullPointerException at org.netbeans.modules.git.ui.blame.AnnotationBar.getBarWidth(AnnotationBar.java:927)
Summary: java.lang.NullPointerException at org.netbeans.modules.git.ui.blame.Annotati...
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.4
Hardware: PC Windows XP
: P2 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-08 09:47 UTC by markiewb
Modified: 2013-09-02 22:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
IDELog of 201308072300 (86.04 KB, text/plain)
2013-08-08 13:15 UTC, markiewb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-08-08 09:47:31 UTC
Reproduction:
* open file of a git-versioned project
* "Team|Show Annotations" to show annotations for this file
* "View|Show Only Editor" to enable fullscreen -> file is opened fullscreen 
* "View|Show Only Editor" to disable fullscreen -> 

ACTUAL: NPE, IDE isn't usable anymore, TopComponent of the file is empty
EXPECTED: no NPE, IDE is usable


SEVERE [global]
java.lang.NullPointerException
	at org.netbeans.modules.git.ui.blame.AnnotationBar.getBarWidth(AnnotationBar.java:927)
	at org.netbeans.modules.git.ui.blame.AnnotationBar.getPreferredSize(AnnotationBar.java:899)
	at org.netbeans.modules.git.ui.blame.AnnotationBarManager.annotationBarVisible(AnnotationBarManager.java:100)
	at org.netbeans.modules.git.ui.blame.AnnotateAction.visible(AnnotateAction.java:187)
	at org.netbeans.modules.git.ui.blame.AnnotateAction.getName(AnnotateAction.java:101)
	at org.openide.util.actions.SystemAction.getValue(SystemAction.java:174)
	at org.openide.awt.Actions$ButtonBridge.updateState(Actions.java:1143)
	at org.openide.awt.Actions$Bridge.addNotify(Actions.java:909)
	at org.openide.awt.Actions$Bridge$VisL.propertyChange(Actions.java:947)
	at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
	at java.awt.Component.firePropertyChange(Component.java:8382)
	at javax.swing.JComponent.addNotify(JComponent.java:4744)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at org.openide.awt.ToolbarWithOverflow.addNotify(ToolbarWithOverflow.java:201)
	at org.openide.awt.Toolbar.addNotify(Toolbar.java:169)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at org.netbeans.core.windows.view.ui.toolbars.ToolbarContainer.addNotify(ToolbarContainer.java:168)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at java.awt.Container.addNotify(Container.java:2769)
	at javax.swing.JComponent.addNotify(JComponent.java:4743)
	at java.awt.Container.addImpl(Container.java:1114)
	at javax.swing.JLayeredPane.addImpl(JLayeredPane.java:230)
	at java.awt.Container.add(Container.java:966)
	at javax.swing.JRootPane.setContentPane(JRootPane.java:625)
	at javax.swing.JFrame.setContentPane(JFrame.java:693)
	at org.netbeans.core.windows.EditorOnlyDisplayer.cancel(EditorOnlyDisplayer.java:155)
	at org.netbeans.core.windows.EditorOnlyDisplayer.setActive(EditorOnlyDisplayer.java:112)
	at org.netbeans.core.windows.actions.ShowEditorOnlyAction.actionPerformed(ShowEditorOnlyAction.java:117)
	at org.openide.windows.TopComponent.processKeyBinding(TopComponent.java:1176)
	at javax.swing.JComponent.processKeyBindings(JComponent.java:2940)
	at javax.swing.JComponent.processKeyEvent(JComponent.java:2842)
	at java.awt.Component.processEvent(Component.java:6282)
	at java.awt.Container.processEvent(Container.java:2229)
	at java.awt.Component.dispatchEventImpl(Component.java:4861)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1895)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:762)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1027)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:899)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:727)
	at java.awt.Component.dispatchEventImpl(Component.java:4731)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Window.dispatchEventImpl(Window.java:2719)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:729)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:688)
	at java.awt.EventQueue$3.run(EventQueue.java:686)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.awt.EventQueue$4.run(EventQueue.java:702)
	at java.awt.EventQueue$4.run(EventQueue.java:700)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:699)
	at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159)
[catch] at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

----
Product Version: NetBeans IDE Dev (Build 201308012300)
Java: 1.7.0_21; Java HotSpot(TM) Client VM 23.21-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_21-b11
System: Windows XP version 5.1 running on x86; Cp1252; de_DE (nb)
Comment 1 Ondrej Vrabec 2013-08-08 10:07:29 UTC
i cannot reproduce, please attach the full ide log
Comment 2 markiewb 2013-08-08 13:15:23 UTC
Created attachment 138448 [details]
IDELog of 201308072300

Still reproducible at
Product Version: NetBeans IDE Dev (Build 201308072300)
Java: 1.7.0_21; Java HotSpot(TM) Client VM 23.21-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_21-b11
System: Windows XP version 5.1 running on x86; Cp1252; de_DE (nb)

See log
Comment 3 Ondrej Vrabec 2013-08-08 14:16:31 UTC
have you extracted the Show Annotations action to the Toolbar?
Comment 4 Ondrej Vrabec 2013-08-08 14:37:25 UTC
fixed: core-main #bfa78a06ae8b
Comment 5 markiewb 2013-08-08 15:11:59 UTC
(In reply to comment #3)
> have you extracted the Show Annotations action to the Toolbar?

Yes I did. Does it matter?
Comment 6 Ondrej Vrabec 2013-08-08 16:35:38 UTC
reproducible only when show annotations action is in toolbar
Comment 7 Quality Engineering 2013-08-09 10:50:28 UTC
Integrated into 'main-silver', will be available in build *201308090746* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/bfa78a06ae8b
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #234127 - java.lang.NullPointerException  at org.netbeans.modules.git.ui.blame.AnnotationBar.getBarWidth(AnnotationBar.java:927)
seems getGraphics() is null when switching to/from fullscreen
Comment 8 markiewb 2013-09-02 22:08:01 UTC
Verified in 201309020001.