This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233311 - [74cat] [dark] [norway today] bad visibility of private static final long serialVersionUID in java
Summary: [74cat] [dark] [norway today] bad visibility of private static final long ser...
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Painting & Printing (show other bugs)
Version: 7.4
Hardware: PC Other
: P3 normal (vote)
Assignee: Miloslav Metelka
URL:
Keywords: NO74
: 234533 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-07-24 12:11 UTC by kosmonaffft
Modified: 2015-05-28 07:13 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Bug screenshot... (98.02 KB, image/png)
2013-07-24 12:11 UTC, kosmonaffft
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kosmonaffft 2013-07-24 12:11:46 UTC
Created attachment 137690 [details]
Bug screenshot...

Product Version: NetBeans IDE Dev (Build 201307222300)
Java: 1.7.0_15; Java HotSpot(TM) 64-Bit Server VM 23.7-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_15-b03

See screenshot...
Comment 1 Jan Lahoda 2013-08-01 20:01:06 UTC
The green that is used for fields is not particularly well visible in Norway Today, especially when the background is mark occurrences background.

Petr, could you please suggest a better color? I tried 33FF00, and it is definitely much better. Is that color OK? (To test it, set Language to Java and change Field Use and Field Declaration categories in Tools/Options/Fonts&Colors/Syntax.)

Also, to it seems that the current line and mark occurrences highlight may be too light - the current line highlight seems to be much more visible than when using the standard white profiles, and mark occurrences highlight then needs to be even lighter. Would it make sense to make these two darker?

Thanks.
Comment 2 Petr Somol 2013-08-01 21:44:51 UTC
(In reply to comment #1)
> The green that is used for fields is not particularly well visible in Norway
> Today, especially when the background is mark occurrences background.
> Petr, could you please suggest a better color? I tried 33FF00, and it is
> definitely much better. Is that color OK? (To test it, set Language to Java and
> change Field Use and Field Declaration categories in
> Tools/Options/Fonts&Colors/Syntax.)

I gave it a try and confirm that your suggestion is good. As far as I am concerned, 33FF00 is OK. I am also CC-ing Standa because his opinion is important here no less.


> Also, to it seems that the current line and mark occurrences highlight may be
> too light - the current line highlight seems to be much more visible than when
> using the standard white profiles, and mark occurrences highlight then needs to
> be even lighter. Would it make sense to make these two darker?

if by current line you mean the brighter background of a line under the cursor, then I do not agree - making this brightening less intense would make it so close to the original color that its purpose would be lost IMHO.

As for mark occurrences it seems too bright as you say. I tried something else than darkening though - take a look like the light magenta FF00FF looks like here. Magentas seem to be used nowhere else so perhaps we could consider this. Standa ?

Also, error background seems quite bright to me. What would you say to CC0000 instead ?

One more pro
Comment 3 Petr Somol 2013-08-01 21:59:14 UTC
...continuing unintentionally unfinished Comment 2:

I thought Parameter Declaration and Use dark brown looked also somewhat strange, but eventually I could not find anything better so I am not proposing any change here.
Comment 4 Stanislav Aubrecht 2013-08-02 09:54:08 UTC
33FF00 for field declarations looks good to me.
Personally I'm not a big fan of magenta-like colors but I don't have a better alternative...
Comment 5 Jan Lahoda 2013-08-05 13:57:54 UTC
Thanks for the colors.

(In reply to comment #2)
> As for mark occurrences it seems too bright as you say. I tried something else
> than darkening though - take a look like the light magenta FF00FF looks like
> here. Magentas seem to be used nowhere else so perhaps we could consider this.
> Standa ?

To me personally, this seems like a little bit to bright/intrusive (for the mark occurrences features). What about 990099 or even 440044?

> 
> Also, error background seems quite bright to me. What would you say to CC0000
> instead ?

Surely better than the current color, thanks. Not sure if using a different effect than a background color would not improve the situation even more. I'll change the color to CC0000 unless there is a better option.
Comment 6 Jan Lahoda 2013-08-19 10:14:31 UTC
*** Bug 234533 has been marked as a duplicate of this bug. ***
Comment 7 Marian Mirilovic 2013-08-23 13:53:12 UTC
Dark themes were moved to the NetBeans Update Center for NB 7.4
Comment 8 Milutin Kristofic 2014-01-14 16:13:15 UTC
This is already fixed by Bug #233807, Bug #2322807, etc.