This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 232232 - Formatter Options should be in SplitPane
Summary: Formatter Options should be in SplitPane
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Options (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Milutin Kristofic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-03 21:32 UTC by markiewb
Modified: 2016-07-10 18:15 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Shows the dialog with missing splitpane (72.33 KB, image/png)
2013-07-03 21:32 UTC, markiewb
Details
Content doesn't resize properly in 201307222300 (543.96 KB, image/png)
2013-07-23 21:34 UTC, markiewb
Details
Current issues with annotations about the proposed solution (781.23 KB, image/png)
2013-07-24 17:17 UTC, markiewb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-07-03 21:32:39 UTC
Created attachment 136681 [details]
Shows the dialog with missing splitpane

EXPECTED: The Formatter Options panel should be placed in a SplitPane so that the user can move resize the tree as he wants.
Comment 1 Milutin Kristofic 2013-07-11 11:32:16 UTC
Thank you for the suggestion.
http://hg.netbeans.org/jet-main/rev/232e00126fb0
Comment 2 Quality Engineering 2013-07-13 02:03:40 UTC
Integrated into 'main-silver', will be available in build *201307122300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/232e00126fb0
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #232232 - Formatter Options should be in SplitPane
Comment 3 markiewb 2013-07-23 21:33:55 UTC
Sorry that I have to reopen the issue. The splitpane was added. Thanks. But the content doesn't resize properly. See the screenshot. Tested in 201307222300
Comment 4 markiewb 2013-07-23 21:34:30 UTC
Created attachment 137649 [details]
Content doesn't resize properly in 201307222300
Comment 5 Milutin Kristofic 2013-07-24 12:26:39 UTC
http://hg.netbeans.org/jet-main/rev/53309832fc9f

Ok, I fixed a resizable space gap in formatting panel and fixed a few java formatting options. 

However I don't know what you are proposing. Components are usually fixed from left and it doesn't look good to have comboboxes on far left side and labels on right side. Comboboxes usually don't need more space, so it is not useful to resize them.
Comment 6 markiewb 2013-07-24 17:17:59 UTC
Created attachment 137724 [details]
Current issues with annotations about the proposed solution
Comment 7 markiewb 2013-07-24 17:25:33 UTC
(In reply to comment #5)
> However I don't know what you are proposing. Components are usually fixed from
> left and it doesn't look good to have comboboxes on far left side and labels on
> right side. Comboboxes usually don't need more space, so it is not useful to
> resize them.

Thanks Milutin for your work and the fast feedback! I addressed my proposals in the updated screenshot https://netbeans.org/bugzilla/attachment.cgi?id=137724

A brief summary: The comboboxes can have their fixed size and also the spinners/textfield can keep their absolute position/size. But all the other components like lines or tables can be resized. Elements which are aligned to the right should be anchored to the right of its outer panel. See the screenshot. I commented each of the separate widgets. I am sure I missed some of the other categories panels. But I think you already got the idea!
Comment 8 Quality Engineering 2013-07-25 02:30:05 UTC
Integrated into 'main-silver', will be available in build *201307242300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/53309832fc9f
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #232232 - Formatter Options should be in SplitPane
Comment 9 Milutin Kristofic 2013-07-25 12:29:46 UTC
Thank you for clarifications. I evaluated it with current change. 
Already Fixed:
1. Spaces - Tree should use 100% 
4. Wrapping - Tree should use 100% 
5. Tabs and Indents - Fixed positions
6. Braces - Lines should resize


Should be fixed
2. Blank Lines - Lines should resize
3. Imports - fix spinners, rest is already fixed.
Comment 10 Milutin Kristofic 2013-07-25 13:08:50 UTC
I fixed blank lines. http://hg.netbeans.org/jet-main/rev/d7e29fa99a82

Import panel has a tricky gap layout. I will try it later.
Comment 11 Quality Engineering 2013-07-27 02:19:47 UTC
Integrated into 'main-silver', will be available in build *201307262300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/d7e29fa99a82
User: Milutin Kristofic <mkristofic@netbeans.org>
Log: #232232 - Formatter Options should be in SplitPane - blanklines panel
Comment 12 Martin Balin 2016-07-07 07:27:38 UTC
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss