This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231797 - UI tweaks in the browser switch megamenu
Summary: UI tweaks in the browser switch megamenu
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 19:49 UTC by Petr Jiricka
Modified: 2013-08-01 02:34 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
UI refinements in the browser megamenu (56.63 KB, image/png)
2013-06-25 19:49 UTC, Petr Jiricka
Details
Browser megagmenu changes (46.11 KB, image/png)
2013-06-26 13:32 UTC, lxlyons
Details
Screenshots of browser switcher on all platforms (669.53 KB, application/zip)
2013-06-28 08:13 UTC, Petr Jiricka
Details
Icons for browser megagmenu (45.81 KB, application/x-zip-compressed)
2013-07-03 16:52 UTC, lxlyons
Details
New windows look (42.42 KB, image/png)
2013-07-11 08:56 UTC, Stanislav Aubrecht
Details
ubuntu screenshot (56.39 KB, image/png)
2013-07-16 03:24 UTC, David Konecny
Details
Linux light specification by the UI designer (41.96 KB, image/png)
2013-07-30 07:26 UTC, Petr Jiricka
Details
Mac light specification by the UI designer (106.29 KB, image/png)
2013-07-30 07:26 UTC, Petr Jiricka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2013-06-25 19:49:37 UTC
Created attachment 136291 [details]
UI refinements in the browser megamenu

Please change the UI of the browser megamenu according to the attached design and e-mail by Liza: 
"That said, can we go forward with the changes proposed in the first sketch? This involves adding the white background, the lighter separators/borders, the lighter gray title text for "With NetBeans Connector," the simplified labels for the options and removal of the NB icon overlay.  Again, I'm trying to keep this simple so it will just work on the different LAFs."
Comment 1 lxlyons 2013-06-26 13:32:55 UTC
Created attachment 136340 [details]
Browser megagmenu changes
Comment 2 Stanislav Aubrecht 2013-06-26 13:41:28 UTC
And how is it supposed to look like on other l&f than Windows? For example on Mac the default background is white. And how about dark color themes?
Or should the change apply to Windows l&f only?

Please clarify and reopen, thanks.
Comment 3 Petr Jiricka 2013-06-28 08:13:29 UTC
Created attachment 136450 [details]
Screenshots of browser switcher on all platforms

Liza, for reference I am attaching a file with screenshots on all platforms (Windows, Mac, Linux) in both light and dark variants.
Comment 4 lxlyons 2013-07-03 16:52:33 UTC
Created attachment 136667 [details]
Icons for browser megagmenu

Please make the changes to the icons, the text and the proposed visual treatment so I can see it all in the windows l&f, and let me know when I can test it.  We will then provide specs for the other lafs.
Comment 5 David Konecny 2013-07-11 00:06:56 UTC
Feel free to assign to me Standa if you prefer me to do it.

I guess it is too late to push this into Beta right?
Comment 6 Stanislav Aubrecht 2013-07-11 08:55:39 UTC
I've changed the Windows UI look as requested core-main 999a3cc4391d
Comment 7 Stanislav Aubrecht 2013-07-11 08:56:33 UTC
Created attachment 136981 [details]
New windows look
Comment 8 David Konecny 2013-07-12 04:27:26 UTC
I updated icons for desktop browsers and removed NB badge: 59e59f748181 - sideeffect is that when Chrome browser is selected for project I have no indication whether I'm using Chrome with NB integration or not. I would argue that badge was helpful in such case.

HonzaB, could you do the same for mobile icons - they are in on of the attachments.

Standa, how should I handle 16x icons? Do I check toolbar size somehow first and then return either 24x icon or 16x one? I would like to resolve also issue 228376 now. Thx.
Comment 9 Jan Becicka 2013-07-12 07:25:47 UTC
changeset   : 258100:2a6f13875d0d
author      : Jan Becicka <jbecicka@netbeans.org>
date        : Fri Jul 12 09:18:02 CEST 2013
summary     : New Icons for mobile browsers
Comment 10 Stanislav Aubrecht 2013-07-12 08:13:03 UTC
(In reply to comment #8)

> Standa, how should I handle 16x icons? Do I check toolbar size somehow first
> and then return either 24x icon or 16x one? I would like to resolve also issue
> 228376 now. Thx.

Check "PreferredIconSize" client property of the toolbar button. If its value is Integer(24) then use big icons.
Comment 11 Quality Engineering 2013-07-13 02:02:18 UTC
Integrated into 'main-silver', will be available in build *201307122300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/59e59f748181
User: David Konecny <dkonecny@netbeans.org>
Log: #231797 - UI tweaks in the browser switch megamenu
Comment 12 David Konecny 2013-07-15 02:41:42 UTC
Thanks Standa, I fixed issue 228376 by using 

    private static boolean isSmallToolbarIcon() {
        return 16 == ToolbarPool.getDefault().getPreferredIconSize();
    }

There is one last issue I have: if toolbar button size is changed how does my code learn about it? ToolbarPool does not seem to have any listener for icon size property. I thought perhaps I could workaround it in my getToolbarPresenter by listening to component size change, eg.:

        button.addComponentListener(new ComponentAdapter() {
            @Override
            public void componentResized(ComponentEvent e) {
                refreshViewLater(true);
            }
        });

but componentResized is called only when small button is changed into big one but not the other way around. What's the right way to resolve this? Thanks.
Comment 13 Stanislav Aubrecht 2013-07-15 08:33:47 UTC
(In reply to comment #12)
 
> There is one last issue I have: if toolbar button size is changed how does my
> code learn about it? ToolbarPool does not seem to have any listener for icon
> size property. I thought perhaps I could workaround it in my
> getToolbarPresenter by listening to component size change, eg.:
> 
>         button.addComponentListener(new ComponentAdapter() {
>             @Override
>             public void componentResized(ComponentEvent e) {
>                 refreshViewLater(true);
>             }
>         });
> 
> but componentResized is called only when small button is changed into big one
> but not the other way around. What's the right way to resolve this? Thanks.

You need to listen to the changes of "PreferredIconSize" client property on the component that is added to the toolbar, i.e. the combo box.
Comment 14 David Konecny 2013-07-15 22:30:23 UTC
Thanks Standa, that works.
Comment 15 David Konecny 2013-07-16 03:24:51 UTC
Created attachment 137164 [details]
ubuntu screenshot

This is how the menu looks on Ubuntu. I assume that it is not finished on Ubuntu as it differs from Windos. Also sometimes I notice it takes about second for menu to come up - it is noticeably slower than other menus.
Comment 16 Vladimir Riha 2013-07-16 06:37:22 UTC
(In reply to comment #8)
> sideeffect is that when Chrome browser is selected for project I have no
> indication whether I'm using Chrome with NB integration or not. I would argue
> that badge was helpful in such case.

I agree with David, I think it was useful to see in "which" Chrome/Chromium the project will run. Now I have to open browser picker to make sure otherwise this information is hidden.
Comment 17 Petr Jiricka 2013-07-30 07:26:25 UTC
Created attachment 137980 [details]
Linux light specification by the UI designer
Comment 18 Petr Jiricka 2013-07-30 07:26:49 UTC
Created attachment 137981 [details]
Mac light specification by the UI designer
Comment 19 Stanislav Aubrecht 2013-07-30 13:18:27 UTC
core-main c7e965e331dd
Comment 20 Quality Engineering 2013-08-01 02:34:44 UTC
Integrated into 'main-silver', will be available in build *201307312300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c7e965e331dd
User: S. Aubrecht <saubrecht@netbeans.org>
Log: #231797 - browser picker tweaks