This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227577 - Select revision dialog: Double click or pressing RETURN on branch/tag-node should select the branch and complete the dialog
Summary: Select revision dialog: Double click or pressing RETURN on branch/tag-node sh...
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-17 00:58 UTC by markiewb
Modified: 2013-03-21 08:21 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Shows the dialog with some annotations (237.18 KB, image/png)
2013-03-17 00:58 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-03-17 00:58:35 UTC 
Created attachment 132705 [details]
Shows the dialog with some annotations

Select revision dialog

* Open the branch node. 
* Select a branch -> the most recent revision of this branch is shown in the details view

ACTUAL:
* you cannot confirm your branch selection and close the dialog via RETURN key (but i already chose the branch)
* you cannot double click to select+confirm the branch and close the dialog (now i have to click the branch node and then i have to click the select button)

EXPECTED:
* pressing the RETURN key on a selected branch node (the tree has to have the focus) should invoke the select button
* double click on a branch node selects the branch AND invokes the select button

IMHO this would improve the usability of the dialog.
Comment 1 Ondrej Vrabec 2013-03-18 13:16:53 UTC 
BTW, there is a convention that NB dialogs accept Ctrl+ENTER combination. So the dialog is not closed by pressing Enter but Ctrl+Enter instead. I'll take a look at the dbl-click
Comment 2 Ondrej Vrabec 2013-03-18 14:20:15 UTC 
fix: http://hg.netbeans.org/core-main/rev/b019296ced3b
Comment 3 Quality Engineering 2013-03-20 02:06:55 UTC 
Integrated into 'main-golden', will be available in build *201303192300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/b019296ced3b
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #227577 - Select revision dialog: Double click or pressing RETURN on branch/tag-node should select the branch and complete the dialog
Comment 4 markiewb 2013-03-21 08:21:27 UTC 
Verified in Build 201303202300