This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Product Version = NetBeans IDE 7.3 (Build 201302132200) Operating System = Windows 7 version 6.1 running on x86 Java; VM; Vendor = 1.6.0_26 Runtime = Java HotSpot(TM) Client VM 20.1-b02 I have customized my own syntax coloring theme. For all languages there is an option for "separator" which colors chars like (,),[,],{,}, etc. But javascript is not colored with that separator color. Its just white. I checked to see if there was an option to adjust the separator color for just javascript and there is not. My code looks unfamiliar without that simple coloring for separators, gonna have to revert to 7.2.1 for now...
Created attachment 131699 [details] IDE log
Probably formatting component? Reassigning
I just tested this on netbeans 7.4 beta and its still a problem.
The "separator" category is available only in Java. JavaScript and PHP doesn't have such category. IMHO this is not showstopper for NB 7.4.
The problem is that JavaScript doesn't take on that value for separator on "All languages" So instead of being the global all languages separator color, its just white. Everyone in my company has not been able update to 7.3 because of this problem. Do what you think is best but I don't see why no one can take a few minutes to look into this bug and knock it out. Thanks
I did the fix in web main: http://hg.netbeans.org/web-main/rev/0eb7cd75b5fc and http://hg.netbeans.org/web-main/rev/d9f6f8e89d4b The fix is not in the code basically, it's just redefinition the categories for tokens {}()[],.;: So the fix should be safe, but should be tested with other themes like CityLights and Dark theme. So it's up to the QA if they want it in NetBeans 7.4, to test it. I'm sorry that I haven't look at this before. If you really think that this is showstopper for NB 7.4, increase the priority back, but I would like to know QE opinion.
If the fix is basically not in the code is there something we can do to modify our own netbeans locally?
Personally I don't think it should go to 7.4, as it is not a serious stopper and it is too late for 7.4.
I'm sorry for the misleading comment. I didn't change a java code from program logic code point of view, it was change in the name of category. Unfortunately the category names, are defined as constants in the code, so you need the whole javascript nbm module file.
Ah I see. Ok, thanks!
Anyway, you can take dev build from http://bits.netbeans.org/download/trunk/nightly/latest/ in Wednesday and there should be the fix. So you can test it and use it.
Awesome, thanks!
> Personally I don't think it should go to 7.4 Agreed, though we may want to consider it for a patch - adding 74patch-candidate.
I think that the solution to add it to the patch is the right way. Thanks.
It appears that the fix has small side effect in the lexer. In the patch has to be also added this change: http://hg.netbeans.org/web-main/rev/675a3e145389
Verified, it is possible to change coloring of {}()[],.;: Product Version: NetBeans IDE Dev (Build 201311040001) Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08 Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
The changes transplanted to the releases: http://hg.netbeans.org/releases/rev/2a723709df89 http://hg.netbeans.org/releases/rev/8105a2883b11 http://hg.netbeans.org/releases/rev/b1830029a09f
Integrated into 'releases/release74', will be available in build *201311141216* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/b1830029a09f User: Petr Pisl <ppisl@netbeans.org> Log: #226484 - JavaScript Syntax Highlighting missing separator
verified in patch Product Version: NetBeans IDE 7.4 (Build 201311142201) Java: 1.7.0_45; Java HotSpot(TM) Client VM 24.45-b08 Runtime: Java(TM) SE Runtime Environment 1.7.0_45-b18 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)