This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 226117 - Source>>Format will operate on any directory through Favorites Window.
Summary: Source>>Format will operate on any directory through Favorites Window.
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 13:10 UTC by MackSix
Modified: 2013-08-04 09:33 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MackSix 2013-02-14 13:10:04 UTC
Source>>Format will operate on any directory, recursively and format all source files it finds through the Favorites Window. There is no way to Undo this unless the source files were open in the editor. 

This is not a good feature and should be disabled for Favorites or some sort of warning and Undo ability. 

Product Version: NetBeans IDE 7.3 (Build 201302132200)
Java: 1.7.0_13; Java HotSpot(TM) 64-Bit Server VM 23.7-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_13-b20
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Comment 1 Jan Lahoda 2013-07-18 08:27:09 UTC
I have added a confirmation dialog:
http://hg.netbeans.org/jet-main/rev/c0d55a1efe9e

Regarding the undo, the feature piggy-backs on the standard refactoring undo (it creates a refactoring session and registers a transaction that can undo the formatting. But the refactoring infrastructure does not enable the undo action while the Favourites tab is selected. I think the global refactoring undo should work from any place in the IDE. Ralph, could you please take a look? Thanks.
Comment 2 Quality Engineering 2013-07-20 02:11:35 UTC
Integrated into 'main-silver', will be available in build *201307192300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c0d55a1efe9e
User: Jan Lahoda <jlahoda@netbeans.org>
Log: #226117: requesting confirmation before recursive formatting.
Comment 3 MackSix 2013-08-04 05:54:21 UTC
Verified Fixed in:

Product Version: NetBeans IDE Dev (Build 201308022300)
Updates: Updates available
Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b16
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)