225574 – I18N: hardcoded strings on glassfish customize dialog

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 225574 - I18N: hardcoded strings on glassfish customize dialog

Summary: I18N: hardcoded strings on glassfish customize dialog

Status:	RESOLVED FIXED

Alias:	None

Product:	serverplugins
Classification:	Unclassified
Component:	GlassFish (show other bugs)
Version:	7.3
Hardware:	All All

Importance:	P3 normal (vote)
Assignee:	Vince Kraemer

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-01-31 07:31 UTC by Masaki Katakai
Modified:	2013-03-26 10:27 UTC (History)
CC List:	0 users

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
screenshot on NetBeans 7.3 RC1 (12.63 KB, image/png) 2013-01-31 07:31 UTC, Masaki Katakai	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Masaki Katakai 2013-01-31 07:31:20 UTC

Created attachment 130866 [details]
screenshot on NetBeans 7.3 RC1

There are 3 strings hardcoded in

glassfish.common/src/org/netbeans/modules/glassfish/common/ui/InstanceCustomizer.java

        targetValueLabel.setLabelFor(targetValueField);
        org.openide.awt.Mnemonics.setLocalizedText(targetValueLabel, "&Target:");

        targetValueField.setEditable(false);

        userNameLabel.setLabelFor(userNameField);
        org.openide.awt.Mnemonics.setLocalizedText(userNameLabel, "&User Name:");

        passwordLabel.setLabelFor(passwordField);
        org.openide.awt.Mnemonics.setLocalizedText(passwordLabel, "Pass&word:");


So these are still English even on localized build.

Please use resource bundle so that these can be localized.

Comment 1 TomasKraus 2013-03-26 10:27:15 UTC

NetBeans web-main:
------------------
changeset:   248977:b724e995a2e8
branch:      javaee7
summary:     #225574 - Hardcoded strings moved to resource bundle