This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 222351 - 'Broken NetBeans Integration Detected' should not open in this scenario
Summary: 'Broken NetBeans Integration Detected' should not open in this scenario
Status: VERIFIED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Extbrowser (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-18 21:49 UTC by David Konecny
Modified: 2012-12-08 02:57 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Konecny 2012-11-18 21:49:12 UTC 
I noticed that sometimes the warning dialog from Chrome popups when it should not. I tracked it down to a reproducible although slightly convoluted case:

* run HTML5 project
* create Chrome new tab and open in it "chrome://chrome/extensions/"; enabled Developer Mode and open Developer Tools for NetBeans Connector extension by clicking on "html/main.html" and keep it open
* close Chrome's tab with HTML5 project and rerun the project from the IDE again (it should reopen in the same Chrome window where you have 'Extensions' tab still open - it if does not then drag the new tab into this old window to merge them into one)
* switch to Extensions tab and close the Chrome window
The last action closes Chrome (apart from Developer Tools windows for NetBeans Connector) and 'Broken NetBeans Integration Detected' is shown even when it should not - I just closed the Chrome browser.
Comment 1 David Konecny 2012-11-18 21:49:43 UTC 
Tomas, could you have a look into this please? Thx.
Comment 2 Tomas Mysik 2012-11-20 06:43:00 UTC 
Will try to fix although the scenario seems to be a bit complicated :)

Thanks for reporting and the exact steps.
Comment 3 Tomas Mysik 2012-12-07 12:01:48 UTC 
Should be fixed now. The warning is now shown always except these cases:
1. user closes NetBeans IDE;
2. the debugged tab is not more visible (tab or its window is closed).

Láďo, please verify, thanks a lot.

Honzo, could you please review the fix? Thanks a lot.

http://hg.netbeans.org/web-main/rev/2690ac5ffde4
Comment 4 Vladimir Riha 2012-12-07 14:35:25 UTC 
Verified, the 2 cases works as Tomas wrote, if I close the infobar or open Chrome DevTools, the dialog is open. Resetting warning also works. 


Product Version: NetBeans IDE Dev (Build web-main-9461-on-20121207)
Java: 1.7.0_10-ea; Java HotSpot(TM) Client VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-ea-b17
System: Linux version 3.2.0-33-generic-pae running on i386; UTF-8; en_US (nb)
Comment 5 Quality Engineering 2012-12-08 02:57:26 UTC 
Integrated into 'main-golden', will be available in build *201212080001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2690ac5ffde4
User: Tomas Mysik <tmysik@netbeans.org>
Log: #222351 - 'Broken NetBeans Integration Detected' should not open in this scenario