This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 221623 - Deploy on Save property cannot be changed
Summary: Deploy on Save property cannot be changed
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Maven (show other bugs)
Version: 7.3
Hardware: PC Windows 7 x64
: P2 normal (vote)
Assignee: Martin Janicek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 11:46 UTC by Jiri Skrivanek
Modified: 2012-11-08 10:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2012-11-07 11:46:15 UTC
It is not possible to change value of Deploy on save property.To reproduce:

- create Maven web project with GlassFish server
- open project properties
- go to Run category
- Deploy on save should be enabled by default
- enable it, click OK
- open properties again but it is again disabled

Product Version: NetBeans IDE Dev (Build 201211070001)
Java: 1.7.0_10-ea; Java HotSpot(TM) 64-Bit Server VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-ea-b11
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
Comment 1 Martin Janicek 2012-11-07 12:25:19 UTC
First part (DoS can be changed in project properties) is fixed in: web-main #57051a5bfb04

There are still two more things to do. Deploy on Save is currently used even if it's explicitly disabled (P2 for sure). And server selection combo box + DoS check box used bold text even in situations where no-one change the value (P4 and another issue in my eyes). I'll create separate ticket for the second problem.
Comment 2 Martin Janicek 2012-11-07 14:08:05 UTC
Ok, I've been playing with this for a while and I think it's working correctly after the fix mentioned in comment 1. Deploy on Save can be disabled in project properties and after clean-build it is not used. 

I thought it's not working correctly because I didn't run clean-build and my expectation was that it should stop using DoS immediately. But it looks like we have never do it this way (Ant web project works equally). Maybe we could at least warn user that he has to run clean-build to see the DoS change because it's not much obvious (similar issue for CoS already exists as issue 201106).

Based on the above I'm closing this issue as fixed and I'm going to create another tickets (P3-P4 I guess) for those minority problems.
Comment 3 Martin Janicek 2012-11-07 14:19:34 UTC
Two minor issue created:

issue 221648 - Server selection label and DoS label are bold without any reason
issue 221649 - Show warning after changing 'Deploy On Save' option - Clean and Build is required

..I'll try to fix both for 7.3 anyway
Comment 4 Martin Janicek 2012-11-07 14:35:49 UTC
Reopening --> I was looking at the wrong place.. in Ant project after disabling DoS, it stops working immediately.
Comment 5 Quality Engineering 2012-11-08 02:51:31 UTC
Integrated into 'main-golden', will be available in build *201211080001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/57051a5bfb04
User: Martin Janicek <mjanicek@netbeans.org>
Log: #221623 - Deploy on Save property cannot be changed
Comment 6 Martin Janicek 2012-11-08 10:26:56 UTC
Closing the issue once again. The web-main #57051a5bfb04 changeset does help.