This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 221079 - JavaScript files in Project Properties merges files with same name
Summary: JavaScript files in Project Properties merges files with same name
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Project (show other bugs)
Version: 7.3
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 12:08 UTC by Vladimir Riha
Modified: 2012-11-03 02:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Riha 2012-10-30 12:08:09 UTC 
If, for whatever reason, I have e.g. this structure:

- js/lib/backbone-0.9.1/backbone.js
- js/lib/backbone-0.9.2/backbone.js

Then in Project Properties|JavaScript files there is "backbone.js" in Selected section only once. I think it could show path/filename (at least up to the first different folder) if there are files with the same name.



Product Version: NetBeans IDE Dev (Build web-main-9034-on-20121030)
Java: 1.7.0_10-ea; Java HotSpot(TM) Client VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-ea-b11
System: Linux version 3.2.0-31-generic-pae running on i386; UTF-8; en_US (nb)
Comment 1 Tomas Mysik 2012-10-30 12:44:35 UTC 
I will change it to relative paths.
Comment 2 David Konecny 2012-10-30 22:13:19 UTC 
(In reply to comment #1)
> I will change it to relative paths.

You mean relative path from project Site Root? I agree.
Comment 3 Tomas Mysik 2012-10-31 08:42:31 UTC 
(In reply to comment #2)
> You mean relative path from project Site Root? I agree.

Yes. Another option could be just relative paths from the Library Folder (the text field) but I guess that it could be more helpful to always see all the JS libraries (files) present in project.
Comment 4 David Konecny 2012-11-01 03:02:12 UTC 
Relative path from project Site Root makes sense to me as developer. The only worry is that path might be too long and listbox is already quite narrow. If space should be an issue an alternative idea is to show items  formatted like this:

angular.js (js/lib/angular1.0)

that is show path after the library name - that way user can see the library names and can scroll to see path if they need to.
Comment 5 Tomas Mysik 2012-11-01 04:50:11 UTC 
Good idea, will do that.
Comment 7 Vladimir Riha 2012-11-02 07:56:28 UTC 
Thanks, verified


Product Version: NetBeans IDE Dev (Build web-main-9082-on-20121102)
Java: 1.7.0_10-ea; Java HotSpot(TM) Client VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-ea-b11
System: Linux version 3.2.0-31-generic-pae running on i386; UTF-8; en_US (nb)
Comment 8 Tomas Mysik 2012-11-02 12:09:06 UTC 
Láďo, could you please verify also on Windows? The code expects only "/" as path separator (I hope it should be fine for ZIP files even on Windows, just want to be sure).

Thanks a lot.
Comment 9 Vladimir Riha 2012-11-02 12:17:52 UTC 
It is OK, JS libraries are properly recognized from ZIP template

Windows 7
Product Version: NetBeans IDE Dev (Build web-main-9082-on-20121102)
Comment 10 Tomas Mysik 2012-11-02 12:22:37 UTC 
Thanks a lot!
Comment 11 Quality Engineering 2012-11-03 02:41:16 UTC 
Integrated into 'main-golden', will be available in build *201211030001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/bab8365f3007
User: Tomas Mysik <tmysik@netbeans.org>
Log: #221079 - JavaScript files in Project Properties merges files with same name