This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 218777 - Cannot profile web application with GlassFish
Summary: Cannot profile web application with GlassFish
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 13:31 UTC by Jiri Skrivanek
Modified: 2012-10-01 08:34 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2012-09-21 13:31:53 UTC 
It might be similar like bug 212011. Simply profiler cannot start. To reproduce:

- install NetBeans 7.3 beta on Windows (default location - space in the path)
- start NetBeans
- create web project with GlassFish server
- right-click project node and choose Profile
- it opens progress dialog which is opened forever
- output in GlassFish output tab is as follows

Profiler Agent: -agentpath:<PATH>/profilerinterface should be called with two parameters:
Profiler Agent: path to Profiler agent libraries and port number, separated by comma, for example:
Profiler Agent: java -agentpath:/mypath/profilerinterface=/home/me/nb-profiler-server/profiler-ea-libs,5140
Error occurred during initialization of VM
agent library failed to init: C:\Program Files\NetBeans 7.3 Beta\profiler\lib\deployed\jdk16\windows-amd64\profilerinterface.dll
Profiler Agent: Initializing...
Profiler Agent: Options: >C:\Program<


Product Version: NetBeans IDE 7.3 Beta (Build 201209201306)
Java: 1.7.0_07; Java HotSpot(TM) 64-Bit Server VM 23.3-b01
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb)
Comment 1 Marian Mirilovic 2012-09-21 14:48:10 UTC 
Mark as a stopper for NB 7.3 Beta
Comment 2 Tomas Hurka 2012-09-21 15:28:23 UTC 
There were no changes in profiler code since fix of issue #212011. I see a lot of changes in glassfish.common, which deals with glassfish startup. So I am reassigning this issue to serverplugins. Please investigate. Thanks.
Comment 3 Marian Mirilovic 2012-09-23 05:50:08 UTC 
Any chance to fix this in next 8 hours ?
Comment 4 Petr Cyhelsky 2012-09-24 08:54:11 UTC 
Integration of profiler with other servers seems to be ok.
Comment 5 TomasKraus 2012-09-24 09:52:11 UTC 
We were already fixing this bug some time ago. Something introduced it again.
Comment 6 TomasKraus 2012-09-24 15:09:53 UTC 
This time it was regression caused by additional quoting in
org.glassfish.tools.ide.server.ServerTasks.appendOptions()
which did not recognized already quoted java option.

I made quick fix to skip quoting for -agentpath: but we need some better solution in the future - mark already quoted arguments and not touch them.

GlassFish Tooling SDK:
----------------------
changeset:   187:58edb4d2ed4e
summary:     Bug# 218777 - Disabled quoting for -agentpath argument

NetBeans:
---------
changeset:   234170:26ef204f93cb
summary:     Bug# 218777 - Disabled quoting for -agentpath argument
Comment 7 TomasKraus 2012-09-24 15:21:37 UTC 
Now works for me on windows with space in the path.
Comment 8 Jiri Skrivanek 2012-09-27 08:10:46 UTC 
Verified in NetBeans IDE Dev (Build 201209250001). Please, transplant to beta branch.
Comment 9 Petr Jiricka 2012-09-27 12:59:35 UTC 
Transplanted to beta branch, and also transplanted the change to use SDK release (not snapshot), so the build is reproducible and reliable.
http://hg.netbeans.org/releases/rev/2231ae267eb6
http://hg.netbeans.org/releases/rev/ec62888a08a3
Comment 10 Jiri Skrivanek 2012-10-01 08:34:01 UTC 
Verified in NetBeans IDE 7.3 Beta (Build 201210010205).