This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 211921 - Local History: Diff to Previous Hangs at "Preparing diff, please wait..."
Summary: Local History: Diff to Previous Hangs at "Preparing diff, please wait..."
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: History (show other bugs)
Version: 7.2
Hardware: PC Windows Vista
: P2 normal (vote)
Assignee: MackSix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 02:33 UTC by MackSix
Modified: 2012-05-18 04:25 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot (178.63 KB, image/png)
2012-05-02 02:37 UTC, MackSix
Details
log file (44.17 KB, application/octet-stream)
2012-05-02 02:38 UTC, MackSix
Details
thread dump (15.25 KB, text/plain)
2012-05-02 14:16 UTC, MackSix
Details
New log file (153.53 KB, application/octet-stream)
2012-05-05 17:32 UTC, MackSix
Details
New thread dump (16.75 KB, text/plain)
2012-05-05 17:33 UTC, MackSix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MackSix 2012-05-02 02:33:20 UTC

    
Comment 1 MackSix 2012-05-02 02:37:26 UTC
1) Open a Java file and create a dozen local history points.
2) View History with History button on toolbar.
3) Change Compare Mode to "Diff to previous".
4) Start at top of history list and slowly click on each entry. Eventually the Diff window will hang at "Preparing diff, please wait..."
5) Try clicking on the next and it may or may not display, but eventually if you click more, the Diff window will display.

See attached screenshot and messages.log file.
Comment 2 MackSix 2012-05-02 02:37:58 UTC
Created attachment 118937 [details]
Screenshot
Comment 3 MackSix 2012-05-02 02:38:18 UTC
Created attachment 118938 [details]
log file
Comment 4 MackSix 2012-05-02 02:56:54 UTC
Product Version: NetBeans IDE Dev (Build 201205010400)
Java: 1.7.0_04; Java HotSpot(TM) Client VM 23.0-b21
System: Windows Vista version 6.0 running on x86; Cp1252; en_US (nb)
Comment 5 Tomas Stupka 2012-05-02 11:48:50 UTC
tried to reproduce a couple of times, but without success. 

please provide a threaddump
Comment 6 MackSix 2012-05-02 14:16:16 UTC
Created attachment 118977 [details]
thread dump

Attached thread dump.
Comment 7 Tomas Stupka 2012-05-02 16:24:57 UTC
still not sure how to reproduce, but running task cancellation when a new entry is selected is obviously insufficient. 
will fix that, add some diagnostic and lets see what happens ...
Comment 8 Tomas Stupka 2012-05-02 17:56:53 UTC
hopefuly fixed in core-main #8b15652b218c

feel free to reopen in case the problem should still appear. 
Please run the IDE with -J-Dorg.netbeans.modules.versioning.ui.history.level=-1 in such a case, reproduce and attach messages.log 
as well as a thread dump created while the progress bar is still running in the diff view.
Comment 9 Quality Engineering 2012-05-04 09:53:19 UTC
Integrated into 'main-golden', will be available in build *201205040400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/8b15652b218c
User: Tomas Stupka <tstupka@netbeans.org>
Log: cancel properly
Issue #211921 - Local History: Diff to Previous Hangs at "Preparing diff, please wait..."
Comment 10 MackSix 2012-05-05 17:32:10 UTC
It seems to be harder to get it to hang now. It seems that I have to click quickly, as soon as the Diff window displays between each line, to get it to hang. If I wait a good second or more between each clicks, it doesn't hang.

I will hang and I have attached a new log file with -J-Dorg.netbeans.modules.versioning.ui.history.level=-1 and thread dump.

Product Version: NetBeans IDE Dev (Build 201205050400)
Java: 1.7.0_04; Java HotSpot(TM) Client VM 23.0-b21
System: Windows Vista version 6.0 running on x86; Cp1252; en_US (nb)
Comment 11 MackSix 2012-05-05 17:32:38 UTC
Created attachment 119121 [details]
New log file
Comment 12 MackSix 2012-05-05 17:33:02 UTC
Created attachment 119122 [details]
New thread dump
Comment 13 Tomas Stupka 2012-05-15 19:07:25 UTC
could reproduce as described above with the addition that it was necessary to click entries which where already once viewed/diffed and therefore cached
Comment 14 Tomas Stupka 2012-05-15 19:36:47 UTC
fixed in core-main #10be4f819b44
Comment 15 Quality Engineering 2012-05-16 11:10:04 UTC
Integrated into 'main-golden', will be available in build *201205160400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/10be4f819b44
User: Tomas Stupka <tstupka@netbeans.org>
Log: Issue #211921 - Local History: Diff to Previous Hangs at "Preparing diff, please wait..."