This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 209482 - Update ANTLR to 3.4
Summary: Update ANTLR to 3.4
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: nnnnnk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 15:40 UTC by nnnnnk
Modified: 2012-07-20 15:43 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
patch (15.21 KB, patch)
2012-03-12 16:06 UTC, nnnnnk 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nnnnnk 2012-03-12 15:40:37 UTC 
It seems that ANTLR 3.4 has bug in DFA generation.
Need if for new C++ grammar.
Comment 1 nnnnnk 2012-03-12 16:06:13 UTC 
Created attachment 116623 [details]
patch
Comment 2 nnnnnk 2012-03-12 16:07:40 UTC 
uploaded binaries on https://hg.netbeans.org/binaries/upload
see hashes in patch
Comment 3 Jesse Glick 2012-03-14 23:37:22 UTC 
You can just delete the <description> from build.xml.

Use 'hg mv' to rename files. Do not copy from a shell and delete the old file, as it loses file history and makes diffs unnecessary verbose.

But if you are going to edit the *-license.txt file, at least make it right according to DevFaqExternalLibraries [1]. "Description" should be one line, "License" should be simply "BSD", "Files" should be used only when there is >1 file (otherwise use e.g. antlr-runtime-3.4-license.txt), license.file is unnecessary.

[1] http://wiki.netbeans.org/DevFaqExternalLibraries
Comment 4 Jesse Glick 2012-04-17 13:13:49 UTC 
Status?
Comment 5 Vladimir Voskresensky 2012-04-17 13:42:15 UTC 
Nik is on vacations for two more weeks.
Comment 6 Jesse Glick 2012-04-17 13:55:47 UTC 
Not a problem, this just seems to have been forgotten.
Comment 7 Leonid Lenyashin 2012-05-21 10:15:12 UTC 
Nikolay, please update the status of this activity
Comment 8 nnnnnk 2012-05-21 13:41:20 UTC 
It happened that we do not need 3.4 for this release.
Changed target milestone to Next.