This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 205230 - MSG_ConfirmDeleteObject and related keys used from other modules
Summary: MSG_ConfirmDeleteObject and related keys used from other modules
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.1
Hardware: All All
: P4 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords:
Depends on:
Blocks: 204945 205217
  Show dependency tree
 
Reported: 2011-11-16 21:20 UTC by Martin Entlicher
Modified: 2012-03-07 18:12 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2011-11-16 21:20:47 UTC 
Messages that are stored in openide.explorer/src/org/openide/explorer/Bundle.properties are used in several other modules.
For instance openide.compat or refactoring.

The messages should either be moved to the individual modules, or some API should be created that would provide the localized Strings. Keys in Bundle.properties files are not public APIs.
Comment 1 Martin Entlicher 2011-11-16 21:21:56 UTC 
See issue #205217.
Comment 2 Jaroslav Tulach 2011-12-05 12:45:37 UTC 
openide.compat and openide.explorer are friends. They even share the same package! I think reuse here is fine (should you pay attention to failing tests, you'd find that out as well soon after integration).

Refactoring is definitely not a friend of openide.explorer and should not reuse its keys.
Comment 3 Jesse Glick 2011-12-05 15:49:15 UTC 
Probably need to do a repository-wide grep for these keys. See bug #205217 comment #5.
Comment 4 Ralph Ruijs 2012-03-06 14:49:35 UTC 
Changeset: 1c47582778e8
Author:    Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Date:      2012-03-06 13:10
Message:   
Issue #205230 - MSG_ConfirmDeleteObject and related keys used from other modules
Comment 5 Jesse Glick 2012-03-06 21:50:21 UTC 
Remember if you are using @Messages you can replace e.g. NbBundle.getMessage(SafeDeleteAction.class, "MSG_ConfirmDeleteObject", sel[0].getDisplayName()) with [Bundle.]MSG_ConfirmDeleteObjectsel[0].getDisplayName()).
Comment 6 Quality Engineering 2012-03-07 18:12:05 UTC 
Integrated into 'main-golden', will be available in build *201203071105* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1c47582778e8
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: Issue #205230 - MSG_ConfirmDeleteObject and related keys used from other modules