This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 204232 - "Shared Libraries" should not be a separate TYPE_GENERIC source root
Summary: "Shared Libraries" should not be a separate TYPE_GENERIC source root
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant Project (show other bugs)
Version: 7.1
Hardware: PC Linux
: P3 normal (vote)
Assignee: Milos Kleint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-25 19:26 UTC by Jesse Glick
Modified: 2013-02-13 01:51 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-10-25 19:26:32 UTC 
7.1 dev. You cannot run the "Project Template" wizard with a j2seproject using a sharable ./lib dir because ProjectUtils.getSources(p).getSourceGroups(Sources.TYPE_GENERIC).length > 1; ./lib is returned as a separate generic root. Since this is inside the main project directory, it should be suppressed.
Comment 1 Milos Kleint 2013-02-11 14:13:37 UTC 
http://hg.netbeans.org/core-main/rev/c4169188fb00

I could not find any area where this would cause problems. please chime in if you know about any..
Comment 2 Jesse Glick 2013-02-11 15:53:53 UTC 
Seems OK; IIRC SourcesHelper already quietly drops registered TYPE_GENERIC roots which are in fact beneath the project root. Other code bypassing SH should do the same.

Beware that FileUtil.isParentOf(sg.getRootFolder(), libLoc) does not include the case that sg.getRootFolder() == libLoc.
Comment 3 Quality Engineering 2013-02-13 01:51:18 UTC 
Integrated into 'main-golden', will be available in build *201302122300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c4169188fb00
User: Milos Kleint <mkleint@netbeans.org>
Log: #204232 only return project library root as separate source group if not inside the default project one.