This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
While editing a JSP page. Taglib functions are not suggested as they used to in version 6.9.1 Example: . . . <%@taglib uri="http://java.sun.com/jsp/jstl/functions" prefix="fn"%> Pressing ctrl-space after ${fn: should display all available functions to choose from, such as: ${fn:contains() NB: Though no suggestions are displayed, invalid functions are highlighted. This functionality is quite important as it is of great assistance to web-developers. Thanks, Turhan Dinletir
Regression.
Looks that there isn't completed support for functions after the rewrite in previous version at all. I started working on that and I'll try to attach the patch then for review from Marek.
Created attachment 113045 [details] patch v1 Ok, I'm attaching patch for offering JSTL functions in CC. There is a piece of code also into Expression Language, so I'm attaching the patch for now if Marek would like to take a look first.
Looks good to me. Do not forget to update module versions properly since you did an incompatible change in web.el
That's really good point, thanks Marek. Ok, I updated a little bit final code (including spec. versions) and should be fixed by web-main #c1d5004554db. Marek pointed also fact, that it's not working also for facelets - issue #190516. But I think that it can stay on P3 since it doesn't looks to be regression. Anyway I will try to take a look on that as well.
I think it's not fixed. Following initial description, if I invoke cc after ${fn: then nothing is offered. It works only if I ommit the ":", so ${fn works. Is it related to this issue or it's something different? Product Version: NetBeans IDE 7.1 RC2 (Build 201111302200) Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10 System: Linux version 3.0.0-13-generic-pae running on i386; UTF-8; en_US (nb)
Created attachment 113734 [details] patch for CC also after semicolon (In reply to comment #6) > I think it's not fixed. Following initial description, if I invoke cc after > ${fn: then nothing is offered. It works only if I ommit the ":", so ${fn works. > Is it related to this issue or it's something different? Probably yes. There is problem that when somebody write semicolon the parser result finishes with error (and it doesn't get to offering JSTL functions at all). I created a patch for that but the question is what can be done on that in this phase of development. Since the first fix I think that the issue is not so serious as before (and could be included into 7.1.1) on the other side the patch already exist (anyway my favourite is 7.1.1 patch). Petr, Marian? BTW, Marek as a owner of web.el could you review that please?
The patch seems ok though I'd possibly use ELSanitizer to sanitize the unparseable code before passing to the EL parser. This is not a stopper for 7.1 IMO. 7.1.1 or even 7.2 is enough as the fix target.
Created attachment 113746 [details] patch v2 for CC also after semicolon Good point Marek, I didn't know ELSanitizer. I rewrote the fix using ELSanitizer. Thanks a lot.
I love the patch #2! Thanks a lot.
Thanks a lot Marek! Integrated into trunk in web-main #e4dce41f2e97.
Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/e4dce41f2e97 User: Martin Fousek <marfous@netbeans.org> Log: #201413 - Taglib functions are not suggested.
verified Product Version: NetBeans IDE Dev (Build 201201010601) Java: 1.7.0_02; Java HotSpot(TM) Client VM 22.0-b10 System: Linux version 3.0.0-14-generic-pae running on i386; UTF-8; en_US (nb)
Transplanted into release71_fixes branch... Summary: #201413 - Taglib functions are not suggested. Changeset: releases #a9e1105cccf9 Summary: increased spec. version, #201413 integration into release71_fixes Changeset: releases #2b8c31b5eff0
verified 7.1.1 Product Version: NetBeans IDE 7.1.1 (Build 201202122200)