This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 196539 - Subversion commit dialog should be able to close by ESC key
Summary: Subversion commit dialog should be able to close by ESC key
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.0
Hardware: PC All
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 10:25 UTC by daniela.waranie
Modified: 2011-04-07 06:43 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description daniela.waranie 2011-03-10 10:25:52 UTC
Maybe this unexpected behavior is on all platforms.

Product Version = NetBeans IDE 7.0 Beta 2 (Build 201102140001)
Operating System = Windows 7 version 6.1 running on x86
Java; VM; Vendor = 1.6.0_22
Runtime = Java HotSpot(TM) Client VM 17.1-b03
Comment 1 Ondrej Vrabec 2011-03-10 11:19:12 UTC
Works fine on Linux and Win Vista x86. What component in the dialog is focused? And how do other dialogs work (Open Project for example)?
Comment 2 daniela.waranie 2011-03-10 12:54:28 UTC
Hi ovrabec,

right now i noticed that ESC works most of the time, but not always.

If click you click with the right mouse button on a file in the commit dialog and click on 'diff' you will get a new tab. If you now hit ESC nothing happens - not sure what element is now focused...

If you now click on the dialog title bar to focus it ESC still do not work. If you click on the tab or into the tab content (but not on all elements) ESC works again - and clicking to the dialog title bar now works again with the ESC key.

After the tab was opened: 
1) selecting "Grafical" works with ESC
2) selecting "Textual" do not work with ESC
3) selecting "Textual" and then "Grafical" do not work with ESC
4) clicking into the code area works with ESC
5) moving the separater between both "files" do not work with ESC
Comment 3 Ondrej Vrabec 2011-03-10 13:59:04 UTC
Thanks for the evaluation. I am able to reproduce also on Linux and in other version control systems.
Comment 4 Ondrej Vrabec 2011-03-10 14:01:35 UTC
fix: http://hg.netbeans.org/core-main/rev/88ef4afe87ab
Comment 5 Quality Engineering 2011-03-11 09:41:32 UTC
Integrated into 'main-golden', will be available in build *201103110400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/88ef4afe87ab
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #196539 - Subversion commit dialog should be able to close by ESC key
Comment 6 daniela.waranie 2011-04-06 22:47:03 UTC
Hi,

I did not find the time to download the nighly builds - so now i am doing my tests with 7.0RC1.

Test results:
After the diff-tab was opened: 
1) works
2) do not work (if you click twice on "Textual" it works, but not on first click)
3) do not work (if you click twice on "Textual" or "Grafical" it works, but not on first click)
4) do not work

Was the fix not part of the RC1?
Comment 7 Ondrej Vrabec 2011-04-07 06:43:22 UTC
(In reply to comment #6)
> Was the fix not part of the RC1?
No, Target milestone is set to Dev - meaning the fix has not been integrated into 7.0 but will be available in whatever release comes after it.