This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 195301 - Produce org.netbeans.api:org-netbeans-libs-junit4
Summary: Produce org.netbeans.api:org-netbeans-libs-junit4
Status: VERIFIED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 7.0
Hardware: All All
: P1 normal (vote)
Assignee: pgebauer
URL:
Keywords:
Depends on: 195300
Blocks:
  Show dependency tree
 
Reported: 2011-02-10 16:18 UTC by Jesse Glick
Modified: 2011-04-21 15:45 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2011-02-10 16:18:37 UTC
http://bits.netbeans.org/netbeans/trunk/maven-snapshot/ does not include the org.netbeans.libs.junit4 module, since it is no longer included in the platform cluster config; must be added anyway (only once bug #195300 is fixed).

Should be fixed for RELEASE70_BETA2.
Comment 1 mperezma 2011-02-12 23:00:36 UTC
Now Beta2 Build 201102111519 is asking for installing junit at the first run. But if the user choose to not install it, junit libraries are still being added to java projects by default. They should be not added to the project as the user decided not to use junit.

I don't know if including org.netbeans.libs.junit4 module will solve this or I should open a new issue.
Comment 2 Jesse Glick 2011-02-14 15:43:26 UTC
(In reply to comment #1)
> Now Beta2 Build 201102111519 is asking for installing junit at the first run.

That is unrelated to this issue, which is about Maven repository generation; please do not discuss here.

> junit libraries are still being added to java projects by default

In Beta 2 yes; not in development builds.
Comment 3 pgebauer 2011-03-08 22:31:24 UTC
Any ideas or tips how the org.netbeans.libs.junit4 module could incorporated into maven repo generation?
Comment 4 Jesse Glick 2011-03-08 22:49:37 UTC
(In reply to comment #3)
> tips how the org.netbeans.libs.junit4 module could incorporated
> into maven repo generation?

Well, you pass a netbeansInstallDirectory to the mojo; libs.junit4 needs to be there somewhere. It is built in the extra cluster during a regular source build, or you can use the <autoupdate> task to install org-netbeans-libs-junit4.nbm.
Comment 5 pgebauer 2011-03-18 22:38:59 UTC
The issue seems to be fixed for the trunk and the release70 branch. The one branch is still missing, the release70_beta2 branch. The org-netbeans-libs-junit4.nbm is not part of the stable.uc cluster thus it's not part of the unpacked-nbms job result.

Is that correct configuration or the org-netbeans-libs-junit4.nbm is missing from the stable.uc cluster configuration?
Comment 6 Jesse Glick 2011-03-18 23:40:36 UTC
org.netbeans.libs.junit4 was built as a regular part of the platform cluster in Beta 2.
Comment 7 pgebauer 2011-03-21 12:20:33 UTC
However the definition of nb.cluster.platform doesn't contain any junit definition in the cluster.properties file besides the string "libs.junit4" isn't presented in the cluster.properties file at all.
Comment 8 Jesse Glick 2011-03-21 13:27:12 UTC
(In reply to comment #7)
> the definition of nb.cluster.platform doesn't contain any junit
> definition in the cluster.properties file

Just in Beta 2, I think, since that used a now-abandoned method for distributing JUnit to users. libs.junit4 can still be built directly in this branch, and it should be published on the Maven repo (with an appropriate external link to junit:junit:4.8.2).
Comment 9 pgebauer 2011-03-25 14:54:50 UTC
The issue is fixed and the maven repository with 70-beta2 artifacts has been released.
Comment 10 Jesse Glick 2011-03-28 17:40:55 UTC
Not really a 70_HR_FIX since there was no source code change to backport - just a change in RE process.
Comment 11 Marian Mirilovic 2011-03-29 00:54:44 UTC
understood - so removing keyword ;)
Comment 12 Jesse Glick 2011-04-21 13:12:45 UTC
Looks to be working. http://bits.netbeans.org/maven2/org/netbeans/api/org-netbeans-libs-junit4/RELEASE70/ exists. *.pom refers to junit:junit:4.8.2 as expected. *.nbm contains just netbeans/modules/ext/junit-4.8.2.jar.external as expected. *.jar manifest specifies Maven-Class-Path: junit:junit:4.8.2 as expected.

http://bits.netbeans.org/netbeans/trunk/maven-snapshot/org/netbeans/api/org-netbeans-libs-junit4/SNAPSHOT/ also looks OK.

I hope that the special treatment of this module was included in the repository publishing script so it will apply also to future releases, not just done as a one-off manual step.
Comment 13 pgebauer 2011-04-21 15:26:24 UTC
> I hope that the special treatment of this module was included in the repository
> publishing script so it will apply also to future releases, not just done as a
> one-off manual step.

The special treatment isn't a manual step however it isn't part of any repository script so far. It's only the script in the Hudson infrastructure. I plan to create a script for maven repo generation and include it into the mercurial repository.
Comment 14 Jesse Glick 2011-04-21 15:45:11 UTC
By "repository publishing script" I meant "script to publish a [Maven] repository", not "publishing script in the [Mercurial] repository". But it would indeed be useful to have this script kept somewhere in nbbuild.