This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I installed a new version of the IDE and pointed at a slightly outdated userdir. In my user settings, I had mounted some filesystems which had obviously moved or been renamed since last use. Here are the issues I noticed: 1) Label text is "Invalid JAR." -- there should not be a "." at the end of this 2) I could not figure out how to see what jar was mounted (what the path was). Instead of the above behavior, I suggest showing the name of the jar as if it is found and badging the filesystem icon with the error badge. In addition, the full path to the jar should be shown in the properties under "Archive File" and that property should be marked as invalid using the property marking capabilities. Possibly, trying to expand the filesystem node in the tree should show an error icon underneath instead of nothing, but I think that's not as important.
The 'Invalid' comes from filesystems. Passing to Radek. Please, before this can get fixed, what is the final proposal from UI team? Would be good to start thread on nbui about this.
"Invalid Jar" does not tell the as much as they would need to know - and this is an excellent use case for both error badging and property marking. I like your suggestion(s) This matter is being discussed on nbui - thread - http://www.netbeans.org/servlets/BrowseList?listName=nbui&by=thread&from=9151
*** Issue 3561 has been marked as a duplicate of this issue. ***
If reason for invalid is missing file path, please use the word "Missing ...". If reason is duplicate path in repository, I suggest "Invalid duplicate ..."
*** Issue 23403 has been marked as a duplicate of this issue. ***
Set target milestone to TBD
*** Issue 10505 has been marked as a duplicate of this issue. ***
Radku, fix please this issue it blocks a issue 26573. I'm not able to apply a fix before it will be fixed.
Target Milestone changed.
Fixed in trunk. Fixed mainly in core and its Ex[Jar,Local]FileSystem. DisplayName doesn't contain Invalid as prefix anymore. There is user FileSystem.Status and its method annotateName. Instead of Invalid was used Missing. Even if jar is missing its name is returned from getDisplayName and not only "Invalid JAR." as it was before. Also refresh on root ensures, that PROP_DISPLAY_NAME is fired. So, if jar is externally copied on its original location, then prefix Missing should disappear. Confusing property isValid from property sheet was set as hidden, beacuse of its semantic is absolutely different from what user could expect. /cvs/openide/src/org/openide/filesystems/Bundle.properties,v <-- Bundle.proper ties new revision: 1.31; previous revision: 1.30 /cvs/openide/src/org/openide/filesystems/JarFileSystem.java,v <-- JarFileSyste m.java new revision: 1.80; previous revision: 1.79 /cvs/openide/src/org/openide/filesystems/LocalFileSystem.java,v <-- LocalFileS ystem.java new revision: 1.62; previous revision: 1.61 /cvs/core/src/org/netbeans/core/ExFsRefreshAction.java,v <-- ExFsRefreshAction .java initial revision: 1.1 /cvs/core/src/org/netbeans/core/ResetJarAction.java,v <-- ResetJarAction.java initial revision: 1.1 /cvs/core/src/org/netbeans/core/Bundle.properties,v <-- Bundle.properties new revision: 1.365; previous revision: 1.364 /cvs/core/src/org/netbeans/core/ExJarFileSystem.java,v <-- ExJarFileSystem.jav a new revision: 1.15; previous revision: 1.14 /cvs/core/src/org/netbeans/core/ExLocalFileSystem.java,v <-- ExLocalFileSystem .java new revision: 1.34; previous revision: 1.33 /cvs/core/src/org/netbeans/beaninfo/FileSystemBeanInfo.java,v <-- FileSystemBe anInfo.java new revision: 1.19; previous revision: 1.18
This is looking better! Has anyone checked cvs/vcs filesystems? Also, on nbui, the property marking and badging were deemed a good idea. Are there plans to implement those as well?
Please address the final comments about badging and vcs.
Martin please look at last comments.
Well, considering this is a P5 priority, I think that it's not worth to solve this in the current dev builds unless this is is an issue in the projects builds as well. In projects builds, I do not see a way, how can a filesystem, that is a part of the master filesystem, become invalid. When the physical folder is removed from disk, the filesystem will not be shown. Thus I suggest to close this as "WONTFIX", because this issue will soon become obsolete. This does not affect issue #26573, because VCS filesystems always display the root path even if they are invalid. Rochelle, if you really need this to be fixed for some later NetBeans 3.x release or S1S 5.x, please reopen, otherwise in NetBeans 4.x this problem will not arise.
I am fine with this justification. What about you Rochelle ? Verifying as won't fix in Projects version.
I'll open a new bug if/when projects are there and there's a similar problem. For now the verification is okay.
Okay, thank you.