This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 173446 - I18N : some strings on THA config panel are not from bundle
Summary: I18N : some strings on THA config panel are not from bundle
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Maria Tishkova
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 04:08 UTC by Masaki Katakai
Modified: 2009-10-09 02:58 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2009-10-01 04:08:09 UTC 
These strings are wrongly marked as NOI18N so "At the startup",
"Manually", "Configure Profile" and "Start" can not be localized.
Could you please extract them to bundle?

./cnd.tha/src/org/netbeans/modules/cnd/tha/actions/THAConfigurationPanel.java:
        startCollectingComboBox.setModel(new javax.swing.DefaultComboBoxModel(new String[] { "At the startup",
"Manually" })); // NOI18N

./cnd.tha/src/org/netbeans/modules/cnd/tha/actions/THAActionsProvider.java:
                DialogDescriptor dialogDescriptor = new DialogDescriptor(configurationPanel, "Configure Profile", true,
options, startB, DialogDescriptor.BOTTOM_ALIGN, null, null);//NOI18N

./cnd.tha/src/org/netbeans/modules/cnd/tha/actions/THAActionsProvider.java:
                JButton startB = new JButton("Start");//NOI18N
Comment 1 Maria Tishkova 2009-10-01 09:46:59 UTC 
Sure, I will fix.
Should I consider this issue as a showstopper for Beta?
Comment 2 Maria Tishkova 2009-10-01 11:01:19 UTC 
1st and 3d items were already fixed some time ago,
the second one is fixed in http://hg.netbeans.org/cnd-main/rev/6bf8178baeeb
Comment 3 Masaki Katakai 2009-10-01 13:02:25 UTC 
Hi Maria, Thank you very much!

Not beta stoppers. I need the fix in trunk.
Comment 4 Quality Engineering 2009-10-05 08:47:35 UTC 
Integrated into 'main-golden', will be available in build *200910030241* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/6bf8178baeeb
User: Maria Tishkova <mromashova@netbeans.org>
Log: fixed IZ#173446  I18N: some strings in THA config panel are not bundled
Comment 5 Masaki Katakai 2009-10-06 04:44:04 UTC 
Hello Maria,

It looks "Start" is still hardcoded. Could you fix?

cnd.tha/src/org/netbeans/modules/cnd/tha/actions/THAMainProjectAction.java:
   JButton startB = new JButton("Start");//NOI18N
Comment 6 Maria Tishkova 2009-10-06 12:05:28 UTC 
fixed in http://hg.netbeans.org/cnd-main?cmd=changeset;node=e90317446da3
Comment 7 Quality Engineering 2009-10-07 00:04:17 UTC 
Integrated into 'main-golden', will be available in build *200910061401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/6bf8178baeeb
User: Maria Tishkova <mromashova@netbeans.org>
Log: fixed IZ#173446  I18N: some strings in THA config panel are not bundled
Comment 8 Quality Engineering 2009-10-07 12:45:10 UTC 
Integrated into 'main-golden', will be available in build *200910070250* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/e90317446da3
User: Maria Tishkova <mromashova@netbeans.org>
Log: fixed IZ#173446 I18N: some string on THA config panel are not from bundle
Comment 9 Masaki Katakai 2009-10-09 02:58:07 UTC 
Verified fix on build 200910080418.

Thank you!