This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 163595 - [67cat] Code completion for columns should display column datatype
Summary: [67cat] Code completion for columns should display column datatype
Status: RESOLVED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: SQL Editor (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker with 1 vote (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: NETFIX, PATCH_AVAILABLE
: 145081 (view as bug list)
Depends on: 69846
Blocks:
  Show dependency tree
 
Reported: 2009-04-24 14:08 UTC by rajivderas
Modified: 2013-05-31 01:20 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
proposed patch v1 (4.85 KB, patch)
2013-05-13 17:10 UTC, matthias42 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rajivderas 2009-04-24 14:08:18 UTC 
Using  NetBeans IDE Dev (Build 200904240201) i connected to the db server derby sql editor and typed a select statement 
like the following 
select * from CUSTOMER where CUSTOMER.CUSTOMER_ID = 1

in the where part of the query when i typed the table name followed by the dot and pressed CTRL + SPACE it showed me 
the respective table columns but how am i supposed check the condition with a parameter without knowing the column type 
where the code completion only shows the column name followed by a string 'table' and the name of the table.

Would it be possible to append at least the column type as an icon in front of the column name followed by a string 
'table' and the name of the table which would be really helpful and will not require the user to check the column data 
type before setting a parameter to that particular column.
Comment 1 Jiri Rechtacek 2009-04-24 14:17:10 UTC 
Right. I will be useful thing. I though about it also. It should be consider in next release NetBeans. Thanks for feedback
Comment 2 Jiri Rechtacek 2009-10-16 14:03:23 UTC 
Reassigned to new owner.
Comment 3 matthias42 2013-05-13 16:57:05 UTC 
*** Bug 145081 has been marked as a duplicate of this bug. ***
Comment 4 matthias42 2013-05-13 17:10:41 UTC 
Created attachment 134386 [details]
proposed patch v1

The attached patch depends on the changes to metadata model introduced by bug #69846. If 69846 is not applied first this patch can still be used, changing getTypeName() in SQLCompletionItems.java to getType().toString().
Comment 5 Jaroslav Havlin 2013-05-21 07:33:47 UTC 
(In reply to comment #4)
> Created attachment 134386 [details]
> proposed patch v1
Thank you for the patch, Matthias.

> If bug 69846 is not applied first this patch can still be used, changing
> getTypeName() in SQLCompletionItems.java to getType().toString().
OK, integrated as http://hg.netbeans.org/core-main/rev/949b8d7c8dd2.
After bug 69846 is fixed, I'll change the code to use getTypeName().
Comment 6 Quality Engineering 2013-05-22 02:36:38 UTC 
Integrated into 'main-golden', will be available in build *201305212300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/949b8d7c8dd2
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #163595: Code completion for columns should display column datatype

Patch by Matthias42.
Comment 7 Jaroslav Havlin 2013-05-29 15:09:07 UTC 
> After bug 69846 is fixed, I'll change the code to use getTypeName().
Fixed in http://hg.netbeans.org/core-main/rev/1c4e07a53c65
The patch has been applied completely. Thank you, Matthias.
Comment 8 Quality Engineering 2013-05-31 01:20:57 UTC 
Integrated into 'main-golden', will be available in build *201305302301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1c4e07a53c65
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #163595: Display native datatype in code completion for columns