This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122875 - Diagram marked dirty if element's SourceCodeArtifact updated
Summary: Diagram marked dirty if element's SourceCodeArtifact updated
Status: NEW
Alias: None
Product: uml
Classification: Unclassified
Component: General Diagram (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@uml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-27 16:39 UTC by Craig Conover
Modified: 2009-05-25 21:06 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Conover 2007-11-27 16:39:36 UTC 
- Create a class diagram
- Add class and inteface elements and name them
- Save All
- Generate code for entire project
Notice that the open diagram gets marked dirty. It should not be.

This will happen to all open diagrams if an element that lives on the diagram is code gen'ed.
Comment 1 Viktor Lapitski 2007-11-27 21:40:44 UTC 
the only changes caused by codegen back to the model 
is the update of source file artifact used later 
for the navigate-to-source feature. I guess the change 
notification gets propagated to the extent 
that diagram is considered updated as well. 
If that is so, i'll minimize the updates 
to an element (ie. no update if the source file artifact 
already points correctly) and re-direct the bug for 
the case when update to source file artifact is really necessary.
Comment 2 Viktor Lapitski 2008-01-29 09:38:28 UTC 
The codegen part, ie. unnecessary updates of SourceFileArtifacts, is fixed. 
The SourceFileArtifacts is still updated when it really necessary, 
that triggers marking of the diagram as dirty because its element 
was updated. With codegen part fixed this happens infrequently 
(only when the set of SourceFileArtifacts is changed) 
Thus i decrease priority of the rest of the issue and transfer it to diagram 
category.


Checking in uml/codegen/src/org/netbeans/modules/uml/codegen/java/JavaCodegen.ja
va;
/cvs/uml/codegen/src/org/netbeans/modules/uml/codegen/java/Attic/JavaCodegen.jav
a,v  <--  JavaCodegen.java
new revision: 1.11.2.6; previous revision: 1.11.2.5
done
Checking in uml/codegen/src/org/netbeans/modules/uml/codegen/java/merging/FileBu
ilder.java;
/cvs/uml/codegen/src/org/netbeans/modules/uml/codegen/java/merging/Attic/FileBui
lder.java,v  <--  FileBuilder.java
new revision: 1.3.2.4; previous revision: 1.3.2.3
done


and 

changeset:   64866:d10e85d2e117
user:        lvv@netbeans.org
date:        Mon Jan 28 23:31:22 2008 -0800
summary:     Fix for codegen part of 122875 Generate Code marks open diagrams di
rty if code genned element(s) lives on the open diagram
Comment 3 George Vasick 2008-06-10 17:11:15 UTC 
Removing obsolete assignments.  Bugs will be reassigned for M2.
Comment 4 Peter Lam 2008-06-19 01:32:39 UTC 
In 6.5, this problem only occurs on an initially selected java project for code gen. After the first time, code gen will
not mark open diagrams dirty.