This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | "List of ignored Folders and Path Patterns"-dialog: Usability improvements - Doubleclick for edit, ESC for close and DEL for remove, default row selection ... | ||
---|---|---|---|
Product: | utilities | Reporter: | markiewb |
Component: | Search | Assignee: | Jaroslav Havlin <jhavlin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | NETFIX |
Priority: | P3 | ||
Version: | 7.3 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Screenshot
SubSubDialog is not visible Proposed patch |
Description
markiewb
2012-09-09 16:56:25 UTC
Created attachment 124186 [details]
Screenshot
Another issue in this context: 3) The dialog should be closeable via "escape"-key. Another issue in this dialog: Deleting multiple rows does not work properly. For example: Click "Add folder", select directories and files and add them. In the dialog select them all, then click "delete". EXPECTED: list is empty ACTUAL: list is not empty Another issue: The "Add folder button" has a different height than the other buttons Created attachment 125723 [details]
SubSubDialog is not visible
Another issue: The subsubdialog does not fit to screen. See screenshot http://netbeans.org/bugzilla/attachment.cgi?id=125723 Created attachment 125724 [details]
Proposed patch
The patch solves the requested fixes/features.
* [fix] rewrite of delete action: collect all deletable items before changing the model - if it would be an ArrayList then a ConcurrentModificationException would have been thrown
* [fix] path pattern dialog will be opened next to parent dialog
* [fix] "Add folder" uses default size (as other buttons - looked strange on nimbus laf)
* [feature] ESC key closes the dialog
* [feature] DEL key removes the selected rows
* [feature] add double click for editing the current row
* [feature] the first row is selected initially
@NetBeans-Devs: Please review the patch and commit.
Integrated as http://hg.netbeans.org/core-main/rev/97fbce507740 You have fixed several usability defects - changing issue type and priority. The fix works perfectly. I've done only some tiny refactoring and formatting. Thank you very much, good job! Integrated into 'main-golden', will be available in build *201210130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/97fbce507740 User: Jaroslav Havlin <jhavlin@netbeans.org> Log: #218030: "List of ignored Folders and Path Patterns"-dialog: Usability improvements |