This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 218030 - "List of ignored Folders and Path Patterns"-dialog: Usability improvements - Doubleclick for edit, ESC for close and DEL for remove, default row selection ...
Summary: "List of ignored Folders and Path Patterns"-dialog: Usability improvements - ...
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: NETFIX
Depends on:
Blocks:
 
Reported: 2012-09-09 16:56 UTC by markiewb
Modified: 2012-10-13 02:09 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot (46.14 KB, image/png)
2012-09-11 20:49 UTC, markiewb 		Details
SubSubDialog is not visible (96.52 KB, image/png)
2012-10-11 00:28 UTC, markiewb 		Details
Proposed patch (7.17 KB, patch)
2012-10-11 00:50 UTC, markiewb 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2012-09-09 16:56:25 UTC 
"List of ignored Folders and Path Patterns"-dialog:
1) It would be an usability improvement to be able to double-click on a row to edit it.
Currently you have to select the line, then click on the edit-button on the right side.
2) The row also could support a context menu with the actions "edit"/"delete".
Comment 1 markiewb 2012-09-11 20:49:00 UTC 
Created attachment 124186 [details]
Screenshot
Comment 2 markiewb 2012-09-11 20:54:19 UTC 
Another issue in this context:
3) The dialog should be closeable via "escape"-key.
Comment 3 markiewb 2012-10-10 23:07:22 UTC 
Another issue in this dialog:

Deleting multiple rows does not work properly.
For example: Click "Add folder", select directories and files and add them. In the dialog select them all, then click "delete".

EXPECTED: list is empty
ACTUAL: list is not empty
Comment 4 markiewb 2012-10-10 23:31:49 UTC 
Another issue: The "Add folder button" has a different height than the other buttons
Comment 5 markiewb 2012-10-11 00:28:35 UTC 
Created attachment 125723 [details]
SubSubDialog is not visible
Comment 6 markiewb 2012-10-11 00:29:16 UTC 
Another issue: The subsubdialog does not fit to screen. See screenshot http://netbeans.org/bugzilla/attachment.cgi?id=125723
Comment 7 markiewb 2012-10-11 00:50:42 UTC 
Created attachment 125724 [details]
Proposed patch

The patch solves the requested fixes/features.
* [fix] rewrite of delete action: collect all deletable items before changing the model - if it would be an ArrayList then a ConcurrentModificationException would have been thrown
* [fix] path pattern dialog will be opened next to parent dialog 
* [fix] "Add folder" uses default size (as other buttons - looked strange on nimbus laf)
* [feature] ESC key closes the dialog
* [feature] DEL key removes the selected rows
* [feature] add double click for editing the current row
* [feature] the first row is selected initially

@NetBeans-Devs: Please review the patch and commit.
Comment 8 Jaroslav Havlin 2012-10-11 09:12:27 UTC 
Integrated as http://hg.netbeans.org/core-main/rev/97fbce507740

You have fixed several usability defects - changing issue type and priority.
The fix works perfectly. I've done only some tiny refactoring and formatting.
Thank you very much, good job!
Comment 9 Quality Engineering 2012-10-13 02:09:11 UTC 
Integrated into 'main-golden', will be available in build *201210130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/97fbce507740
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #218030: "List of ignored Folders and Path Patterns"-dialog: Usability improvements