This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | remote synchronization occurs when downloading files | ||
---|---|---|---|
Product: | php | Reporter: | Filip Zamboj <fzamboj> |
Component: | FTP Support | Assignee: | Tomas Mysik <tmysik> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fzamboj, rmatous, stephenliberty, tmysik |
Priority: | P3 | Keywords: | RANDOM |
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Fix |
Description
Filip Zamboj
2010-01-09 16:57:49 UTC
Sorry, not possible to find out the source of the file-change event and in fact, it's against the idea behind upload-on-save fundtionality. If it's really problem, then disable upload-on-save, download files and enable upload-on-save again. Reopening because of bug #179347. *** Bug 180378 has been marked as a duplicate of this bug. *** OK, I will add some UI for temporary disabling of upload-on-save feature, I hope it will be possible. Fixed, it should work (but not for opened files in the editor, these are uploaded back, sorry this seems to be not fixable). If not, please reopen and provide exact steps to reproduce. Filipe, please, check that upload-on-save is not broken. Thanks. http://hg.netbeans.org/web-main/rev/bad3bd9d59e4 Integrated into 'main-golden', will be available in build *201002100200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/bad3bd9d59e4 User: Tomas Mysik <tmysik@netbeans.org> Log: #179347: remote synchronization occurs when downloading files v/c Product Version: NetBeans IDE Dev (Build 2010-02-11_03-04-28 ) Java: 1.6.0_16; Java HotSpot(TM) 64-Bit Server VM 14.2-b01 closed to fast :) - I reproduced => not done yet. Sometimes it works, sometimes does not. I will try to investigate why. It's random and seems to be a bug in FS, I will investigate more... Caused by using java.io.File in download method of the remote client. Perhaps too risky for NB 6.9. Created attachment 101291 [details]
Fix
Attached fix.
Basically this is what happens:
1. netbeans.php downloads file
2. netbeans.php overwrites current file, so time of last file change is modified
3. netbeans.php gets events of file modification
4. netbeans.php uploads file back, becouse after all file changes it does so
My fix makes netbeans.php ignore fileChange event if file has been downloaded by netbeans.php itself
thanks for the fix. We will have a look. Radku, could you please review the patch? I'm not sute it is correct. batch reassigning Batch reassigning. This should work now I think since we are using FileObjects only. If not, please reopen, I will investigate more. Thanks. |