HR integration review request: #223912 - Enabling on save actions breaks Refactoring

  • From: Jan Lahoda < >
  • To:
  • Subject: HR integration review request: #223912 - Enabling on save actions breaks Refactoring
  • Date: Mon, 14 Jan 2013 13:39:37 +0100

Description:
http://netbeans.org/bugzilla/show_bug.cgi?id=223912

Refactoring undo does not work when on save tasks are enabled, and modified the file while the refactoring was committed. This is caused by a checksum mismatch between the supposed refactoring result and the real on-disk content. Fixed by disabling the on save tasks while the refactoring is being committed and undone. This might be seen unwelcome or unexpected by some users, but the same is true for running the on save tasks during refactoring.

Impact assessment: Undo not working for refactoring.

Risk assessment: low - the behavior should be basically the same as if the on save tasks would be disabled in the Tools/Options.

Reviewed by Ralph Ruijs. QA verification by Jirka Prox.

Changeset:
http://hg.netbeans.org/jet-main/rev/4130b9ad2186

Thanks for review,
   Jan



HR integration review request: #223912 - Enabling on save actions breaks Refactoring

Jan Lahoda 01/14/2013

Re: HR integration review request: #223912 - Enabling on save actions breaks Refactoring

Jan Lahoda 01/16/2013

HR integration review request: #224879 - Incorrect unused assignment warning

Jan Lahoda 01/16/2013

HR integration review request: #224988 - Null Pointer Dereference warning for @Nullable fields when field processing is disabled

Jan Lahoda 01/17/2013

HR integration review request: #225107 - Pull Up Method To Abstract Super Class Ads Extraneous Comments

Jan Lahoda 01/21/2013

Project Features

About this Project

www was started in November 2009, is owned by jpirek, and has 21 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20140418.2d69abc). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close