[api-changes] [Bug 210465] Distinguish required projects from submodules

  • From:
  • To:
  • Subject: [api-changes] [Bug 210465] Distinguish required projects from submodules
  • Date: Wed, 20 Mar 2013 08:59:50 +0000
  • Auto-submitted: auto-generated

http://netbeans.org/bugzilla/show_bug.cgi?id=210465

--- Comment #19 from Milos Kleint 
< >
 2013-03-20 08:59:50 UTC ---
(In reply to comment #16)
> Y01 Separate API and SPI: Rather than putting all the burden on clients and
> forcing them to call into two SPI(!) interfaces, please enhance 
> ProjectUtils.
> Something in the style of ProjectInformation - e.g. static method(s) that 
> know
> what to call and never return null. Let's add something like:
> 

Done in the attached new patch. However only the new approach gets API 
haircut,
the old SubprojectProvider keeps on being used as before..

> 
> Clients should be encouraged to call these API methods rather than dealing 
> with
> content of lookup directly. The names, meaning of the methods is tbd., but
> there should be one method that does exactly the same thing in new version 
> as
> it did in 7.3.

That's not really possible for maven projects. The entire point of the issue 
is
*not* to do the same as in 7.3 (in SubprojectProvider) and for those who 
relied
on the old behaviour we have the new API now. And BTW the old
SubprojectProvider javadoc is fairly vague in terms of what is inside that I
actually could start returning different values for maven projects *without*
any new API..

> 
> Y02 Write a hint to convert direct calls to SubprojectProvider with the 
> call to
> getReleatedProjects (if that is the replacement that remains compatible)

out of scope, and not so many uses anyway..

> 
> Y03 "Dependency projects" sound weird. Should not the method be named
> "getProjectDependencies()"?

IMHO getProjectDependencies suggests to return the entire list of 
dependencies,
but we only return the projects here. getDependencyProjects is more correct
here.

-- 
Configure bugmail: http://netbeans.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


[api-changes] [Bug 210465] Distinguish required projects from submodules

(continued)

[api-changes] [Bug 210465] Distinguish required projects from submodules

jglick 03/15/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/15/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/15/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

jglick 03/15/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/18/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

jglick 03/18/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/19/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

jtulach 03/20/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/20/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/20/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/20/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

jglick 03/20/2013

[api-changes] [Bug 210465] Distinguish required projects from submodules

mkleint 03/20/2013

Project Features

About this Project

www was started in November 2009, is owned by jpirek, and has 21 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20131025.e7cbc9d). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close