[api-changes] [Bug 224328] Find in Projects always using regular expressions

  • From:
  • To:
  • Subject: [api-changes] [Bug 224328] Find in Projects always using regular expressions
  • Date: Tue, 05 Feb 2013 16:06:45 +0000
  • Auto-submitted: auto-generated

http://netbeans.org/bugzilla/show_bug.cgi?id=224328


 changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130823|0                           |1
        is obsolete|                            |

--- Comment #24 from 

 2013-02-05 16:06:45 UTC ---
Created attachment 131040
  --> http://netbeans.org/bugzilla/attachment.cgi?id=131040
Proposed Patch v3

(In reply to comment #21)
> 1) It is (the default value in the API) currently BASIC, but I think it
>    would be better to change it to LITERAL.
> 2) Default value in the UI. I agree it should be LITERAL, too.
Both fixed.

> > One more suggestion. Now the label (if I understand it right) is Type:.
> > I guess the better label would be Match:, because it would state more
> > precisely what the choice is about, instead of just Type what might
> > mean anything.
> Good idea.
Fixed.

I've realized that there could be problems with SearchPatternControllers:
1) If the combo box doesn't contain mandatory REGEXP and LITERAL items.
2) If we try to set a SearchPattern (method setSearchPattern) with MatchType 
   that is not contained in the bound combo box.
3) If the combo box contains items that are not instances of MatchType.

Proposed Patch v3 fixes this (some checks added).

Please note that API of SearchPatternController has changed:

 - Enum MultiOption (with a single value) was removed
 - Method bind(MultiOption, JComboBox) was replaced with 
   bindMatchTypeComboBox(textToFindType).

I'm sorry for changing the proposed API. I hope it will be beneficial.
Please review it.

Thank you.

-- 
Configure bugmail: http://netbeans.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/04/2013

<Possible follow-up(s)>

[api-changes] [Bug 224328] Find in Projects always using regular expressions

mkristofic 02/04/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

ralphbenjamin 02/04/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/06/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/13/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/14/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

quality 02/16/2013

Project Features

About this Project

www was started in November 2009, is owned by jpirek, and has 21 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20140418.2d69abc). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close