[api-changes] [Bug 224328] Find in Projects always using regular expressions

  • From:
  • To:
  • Subject: [api-changes] [Bug 224328] Find in Projects always using regular expressions
  • Date: Mon, 04 Feb 2013 13:48:57 +0000
  • Auto-submitted: auto-generated

http://netbeans.org/bugzilla/show_bug.cgi?id=224328

--- Comment #21 from 

 2013-02-04 13:48:57 UTC ---
(In reply to comment #20)
> I slightly incline to agree that LITERAL might be the more natural default 
> (as
> you say, when people copy/paste search string from elsewhere then LITERAL is
> more likely to be the expected mode. 

There are two different questions which are not the same, but it is probably
better if they are consistent.

1) Default value in the API, used if the SearchPattern is created with 
factory 
   method that only specifies that the pattern is not regular expression: 

   assertEquals("If not specified exactly, match type should be BASIC",
              MatchType.BASIC, 
              SearchPattern.create("test", false, false, false).getMatchType()
   );

   It is currently (in Proposed Patch v2) BASIC, but I think it 
   would be better to change it to LITERAL.
   Ralph, would it be OK for you?

2) Default value in the UI. I agree it should be LITERAL, too.

> There might be people who are used to the current default behavior though 
> who might disagreee - but for them this should be only slightly annoying,
> provided the choice is persisted. Do you plan to persist this? 
Yes, it will be persisted.

> One more suggestion. Now the label (if I understand it right) is Type:. 
> I guess the better label would be Match:, because it would state more
> precisely what the choice is about, instead of just Type what might 
> mean anything.
Good idea.

Thank you for your comments.

-- 
Configure bugmail: http://netbeans.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/04/2013

<Possible follow-up(s)>

[api-changes] [Bug 224328] Find in Projects always using regular expressions

mkristofic 02/04/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

ralphbenjamin 02/04/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/05/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/06/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/13/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

jhavlin 02/14/2013

[api-changes] [Bug 224328] Find in Projects always using regular expressions

quality 02/16/2013

Project Features

About this Project

www was started in November 2009, is owned by jpirek, and has 21 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20131025.e7cbc9d). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close