[api-changes] [Bug 208841] Enhance test runner

  • From:
  • To:
  • Subject: [api-changes] [Bug 208841] Enhance test runner
  • Date: Mon, 27 Feb 2012 20:17:56 +0000
  • Auto-submitted: auto-generated

http://netbeans.org/bugzilla/show_bug.cgi?id=208841

--- Comment #6 from Jesse Glick 
< >
 2012-02-27 20:17:56 UTC ---
Next time please include the BZ number in the branch name, e.g.
"testng_208841".


Also too late now, but next time you want to move modules between 
repositories,
do it with history:

http://wiki.netbeans.org/HgHowTos#Transfer_a_module.27s_history_to_another_repository


Also some thing look like they were renames, but are not marked in history 
this
way; junit/src/org/netbeans/modules/junit/JUnitCfgOfCreate.java ->
gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/CommonTestsCfgOfCreate.java
for example.


Also do not comment things out in layer.xml files; it makes the diff quite
confusing and inevitably leaves trash behind for years. If an entry is no
longer needed, delete it.


[JG01] Suggest the package prefix org.netbeans.modules.testng, not
org.netbeans.modules.contrib.testng.

BTW do not forget that new modules must be added to some plugin or another,
e.g. java.kit.


[JG02] gsf.testrunner may not depend on api.java nor java.project modules,
because it is in the ide cluster. Perhaps you meant to add new APIs to
java.project or some new module in the java cluster ("java.tests"?), rather
than cluttering gsf.testrunner with things specific to the Java language which
would not be used e.g. by Ruby support.

Fixing this will require a big rearrangement of sources, so there is not much
sense reviewing the branch further until this is done.


[JG03] The "API" looks like it is packed with implementation classes which do
not belong there. What is the use case for a client referring directly to
org.netbeans.modules.gsf.testrunner.api.TestCreatorAction, for example?


[JG04] Suggest moving the "TestNG-6.4beta" library, as well as
testng-6.4beta-javadoc.zip, to testng.ant, moving the addLibrary method to
AntTestNGSupport, and making MavenTestNGSupport.configureProject directly add
the desired POM dependency.

-- 
Configure bugmail: http://netbeans.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


[api-changes] [Bug 208841] Enhance test runner

theofanis 02/24/2012

<Possible follow-up(s)>

[api-changes] [Bug 208841] Enhance test runner

jungi 02/24/2012

[api-changes] [Bug 208841] Enhance test runner

pjiricka 02/27/2012

[api-changes] [Bug 208841] Enhance test runner

theofanis 02/27/2012

[api-changes] [Bug 208841] Enhance test runner

jglick 02/27/2012

[api-changes] [Bug 208841] Enhance test runner

jglick 02/28/2012

[api-changes] [Bug 208841] Enhance test runner

jungi 02/29/2012

Project Features

About this Project

www was started in November 2009, is owned by jpirek, and has 21 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20131025.e7cbc9d). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close