[hg] main-silver: #225460: Do not activate the Evaluator compone...

  • From:
  • To: , ,
  • Subject: [hg] main-silver: #225460: Do not activate the Evaluator compone...
  • Date: Fri, 01 Feb 2013 10:19:11 -0800

changeset 13245c41fd01 in main-silver ((none))
details: http://hg.netbeans.org/main-silver/rev/13245c41fd01
description:
        #225460: Do not activate the Evaluator component if the view we're 
opening was minimized. Activation of Evaluator causes immediate minimization 
again.

diffstat:

 
debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/CodeEvaluator.java 
                      |  5 +++++
 
web.javascript.debugger/src/org/netbeans/modules/web/javascript/debugger/eval/ui/CodeEvaluator.java
 |  5 +++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diffs (58 lines):

diff --git 
a/debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/CodeEvaluator.java
 
b/debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/CodeEvaluator.java
--- 
a/debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/CodeEvaluator.java
+++ 
b/debugger.jpda.ui/src/org/netbeans/modules/debugger/jpda/ui/CodeEvaluator.java
@@ -569,9 +569,11 @@
         //DialogDisplayer.getDefault().notify(new 
NotifyDescriptor.Message(var.getValue()));
         SwingUtilities.invokeLater(new Runnable() {
             public void run() {
+                boolean isMinimized = false;
                 if (preferences.getBoolean("show_evaluator_result", true)) {
                     TopComponent view = 
WindowManager.getDefault().findTopComponent("localsView"); // NOI18N [TODO]
                     view.open();
+                    isMinimized = 
WindowManager.getDefault().isTopComponentMinimized(view);
                     view.requestActive();
                 } else {
                     if (resultView == null) {
@@ -579,10 +581,13 @@
                     }
                     if (result != null) {
                         resultView.open();
+                        isMinimized = 
WindowManager.getDefault().isTopComponentMinimized(resultView);
                         resultView.requestActive();
                     }
                 }
+                if (!isMinimized) {
                 getInstance().requestActive();
+                }
                 fireResultChange();
             }
         });
diff --git 
a/web.javascript.debugger/src/org/netbeans/modules/web/javascript/debugger/eval/ui/CodeEvaluator.java
 
b/web.javascript.debugger/src/org/netbeans/modules/web/javascript/debugger/eval/ui/CodeEvaluator.java
--- 
a/web.javascript.debugger/src/org/netbeans/modules/web/javascript/debugger/eval/ui/CodeEvaluator.java
+++ 
b/web.javascript.debugger/src/org/netbeans/modules/web/javascript/debugger/eval/ui/CodeEvaluator.java
@@ -598,9 +598,11 @@
         SwingUtilities.invokeLater(new Runnable() {
             @Override
             public void run() {
+                boolean isMinimized = false;
                 if (preferences.getBoolean("show_evaluator_result", true)) {
                     TopComponent view = 
WindowManager.getDefault().findTopComponent("localsView"); // NOI18N [TODO]
                     view.open();
+                    isMinimized = 
WindowManager.getDefault().isTopComponentMinimized(view);
                     view.requestActive();
                 } else {
                     if (resultView == null) {
@@ -608,10 +610,13 @@
                     }
                     if (result != null) {
                         resultView.open();
+                        isMinimized = 
WindowManager.getDefault().isTopComponentMinimized(resultView);
                         resultView.requestActive();
                     }
                 }
+                if (!isMinimized) {
                 getInstance().requestActive();
+                }
                 fireResultChange();
             }
         });

[hg] main-silver: #225460: Do not activate the Evaluator compone...

mentlicher 02/01/2013

Project Features

About this Project

Debugger was started in November 2009, is owned by tpavek, and has 29 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20131025.e7cbc9d). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close