[hg] main-silver: Issue #240165 - StackOverflowError at java.uti...

  • From: Tomas Stupka < >
  • To:
  • Subject: [hg] main-silver: Issue #240165 - StackOverflowError at java.uti...
  • Date: Fri, 10 Jan 2014 04:50:54 +0000

changeset d5d270790f64 in main-silver ((none))
details: http://hg.netbeans.org/main-silver/rev/d5d270790f64
description:
        Issue #240165 - StackOverflowError at java.util.Properties.getProperty

diffstat:

 jira/src/org/netbeans/modules/jira/JiraConnector.java               |   2 +-
 jira/src/org/netbeans/modules/jira/query/JiraQueryCellRenderer.java |  38 
----------
 jira/src/org/netbeans/modules/jira/util/JiraUtils.java              |   8 --
 jira/test/unit/src/org/netbeans/modules/jira/JiraTestUtil.java      |   2 +-
 4 files changed, 2 insertions(+), 48 deletions(-)

diffs (90 lines):

diff --git a/jira/src/org/netbeans/modules/jira/JiraConnector.java 
b/jira/src/org/netbeans/modules/jira/JiraConnector.java
--- a/jira/src/org/netbeans/modules/jira/JiraConnector.java
+++ b/jira/src/org/netbeans/modules/jira/JiraConnector.java
@@ -144,7 +144,7 @@
         String product = location.substring(idx + "/browse/".length()); // 
NOI18N
 
         KenaiRepository repo = new KenaiRepository(project, 
project.getDisplayName(), url, host, product);
-        return JiraUtils.getRepository(repo);
+        return JiraUtils.createRepository(repo);
         
     }
 
diff --git 
a/jira/src/org/netbeans/modules/jira/query/JiraQueryCellRenderer.java 
b/jira/src/org/netbeans/modules/jira/query/JiraQueryCellRenderer.java
--- a/jira/src/org/netbeans/modules/jira/query/JiraQueryCellRenderer.java
+++ b/jira/src/org/netbeans/modules/jira/query/JiraQueryCellRenderer.java
@@ -235,44 +235,6 @@
         QueryTableCellRenderer.setRowColors(style, panel);
     }
 
-    private void addParentAction(int row, int column, JLabel label, final 
NbJiraIssue issue) {
-        issueTable.addCellAction(row, column, label.getBounds(), new 
ActionListener() {
-            @Override
-            public void actionPerformed(ActionEvent e) {
-                String id = issue.getParentID();
-                NbJiraIssue parent = (NbJiraIssue) 
issue.getRepository().getIssueCache().getIssue(id);
-                if(parent != null) {
-                    JiraUtils.openIssue(parent);
-                } else {
-                    
Util.openIssue(JiraUtils.getRepository(issue.getRepository()), id); // XXX 
show a wrong message in progress bar! opening ID instead of opening KEY
-                }
-            }
-        });
-    }
-
-    /**
-     * DO NOT call if query not saved yet.
-     * 
-     * @return 
-     */
-    private Query getQuery() {
-        if(query == null)  {
-            assert jiraQuery.isSaved();
-            Repository repository = 
JiraUtils.getRepository(jiraQuery.getRepository());
-            Collection<Query> queries = repository.getQueries();
-            Query aQuery = null;
-            for (Query q : queries) {
-                if(q.getDisplayName().equals(jiraQuery.getDisplayName())) {
-                    aQuery = q;
-                    break;
-                }
-            }
-            this.query = aQuery;
-            assert query != null;        
-        }
-        return query;
-    }
-
     private class TwoLabelPanel extends JPanel {
         RendererLabel north = new RendererLabel();
         RendererLabel south = new RendererLabel();
diff --git a/jira/src/org/netbeans/modules/jira/util/JiraUtils.java 
b/jira/src/org/netbeans/modules/jira/util/JiraUtils.java
--- a/jira/src/org/netbeans/modules/jira/util/JiraUtils.java
+++ b/jira/src/org/netbeans/modules/jira/util/JiraUtils.java
@@ -346,14 +346,6 @@
         return null;
     }
 
-    public static Repository getRepository(JiraRepository jiraRepository) {
-        Repository repository = 
RepositoryManager.getInstance().getRepository(JiraConnector.ID, 
jiraRepository.getID());
-        if(repository == null) {
-            repository = createRepository(jiraRepository);
-        }
-        return repository;
-    }
-
     public static Repository createRepository(JiraRepository jiraRepository) 
{
         return Jira.getInstance().getBugtrackingFactory().createRepository(
                 jiraRepository,
diff --git a/jira/test/unit/src/org/netbeans/modules/jira/JiraTestUtil.java 
b/jira/test/unit/src/org/netbeans/modules/jira/JiraTestUtil.java
--- a/jira/test/unit/src/org/netbeans/modules/jira/JiraTestUtil.java
+++ b/jira/test/unit/src/org/netbeans/modules/jira/JiraTestUtil.java
@@ -379,7 +379,7 @@
     }
     
     public static Query getQuery(JiraQuery jiraQuery) {
-        return getQuery(JiraUtils.getRepository(jiraQuery.getRepository()), 
jiraQuery);
+        return 
getQuery(JiraUtils.createRepository(jiraQuery.getRepository()), jiraQuery);
     }        
     
     private static Query getQuery(Repository repository, JiraQuery q) {

[hg] main-silver: Issue #240165 - StackOverflowError at java.uti...

Tomas Stupka 01/10/2014

Project Features

About this Project

ConnectedDeveloper was started in November 2009, is owned by tpavek, and has 66 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20140418.2d69abc). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close