[hg] main-silver: removed obsolete fields and methods in issue c...

  • From: Tomas Stupka < >
  • To:
  • Subject: [hg] main-silver: removed obsolete fields and methods in issue c...
  • Date: Thu, 04 Apr 2013 00:31:48 -0700

changeset 1fbb20ce006a in main-silver ((none))
details: http://hg.netbeans.org/main-silver/rev/1fbb20ce006a
description:
        removed obsolete fields and methods in issue cache

diffstat:

 bugtracking/manifest.mf                                                      
                         |   2 +-
 
bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueCache.java
                       |  73 +--------
 
bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueSettingsStorage.java
             |   6 +-
 
bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueStorage.java
                     |  72 ++++-----
 
bugtracking/test/unit/src/org/netbeans/modules/bugtracking/issuetable/QueryTableCellRendererTest.java
 |   6 +-
 
bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/CacheTest.java
              |   8 +-
 
bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/StorageTest.java
            |   7 +-
 bugzilla/nbproject/project.xml                                               
                         |   2 +-
 
bugzilla/src/org/netbeans/modules/bugzilla/repository/BugzillaRepository.java 
                        |  11 +-
 jira/nbproject/project.xml                                                   
                         |   2 +-
 jira/src/org/netbeans/modules/jira/repository/JiraRepository.java            
                         |  11 +-
 11 files changed, 55 insertions(+), 145 deletions(-)

diffs (581 lines):

diff --git a/bugtracking/manifest.mf b/bugtracking/manifest.mf
--- a/bugtracking/manifest.mf
+++ b/bugtracking/manifest.mf
@@ -3,5 +3,5 @@
 OpenIDE-Module: org.netbeans.modules.bugtracking
 OpenIDE-Module-Layer: org/netbeans/modules/bugtracking/layer.xml
 OpenIDE-Module-Localizing-Bundle: 
org/netbeans/modules/bugtracking/Bundle.properties
-OpenIDE-Module-Specification-Version: 1.47
+OpenIDE-Module-Specification-Version: 1.48
 
diff --git 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueCache.java
 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueCache.java
--- 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueCache.java
+++ 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueCache.java
@@ -98,13 +98,11 @@
     private Map<String, IssueEntry> cache;
     private Map<String, Map<String, String>> lastSeenAttributes;
 
-    private String nameSpace;
+    private final String nameSpace;
 
     private final Object CACHE_LOCK = new Object();
-    private long referenceTime;
+    private final long referenceTime;
     private final IssueAccessor<I, D> issueAccessor;
-    private final IssueProvider<I> issueProvider;
-    private final RepositoryImpl repository;
 
     /**
      *
@@ -145,14 +143,6 @@
         public Map<String, String> getAttributes(I issue);
 
         /**
-         * Returns a description summarizing the changes made
-         * in the given issue since the last time it was as seen.
-         *
-         * @return
-         */
-        public String getRecentChanges(I issue);
-
-        /**
          * Returns the last modification time for the given issue
          *
          * @issue issue
@@ -168,7 +158,6 @@
          */
         public long getCreated(I issue);
 
-
     }
 
     /**
@@ -177,19 +166,18 @@
      * @param nameSpace
      * @param issueAccessor
      */
-    public IssueCache(String nameSpace, IssueAccessor<I, D> issueAccessor, 
IssueProvider<I> issueProvider, Repository repository) {
+    public IssueCache(String nameSpace, IssueAccessor<I, D> issueAccessor) {
         assert issueAccessor != null;
         this.nameSpace = nameSpace;
         this.issueAccessor = issueAccessor;
-        this.issueProvider = issueProvider;
-        this.repository = APIAccessor.IMPL.getImpl(repository);
 
+        long t = System.currentTimeMillis(); // fallback
         try {
-            this.referenceTime = 
IssueStorage.getInstance().getReferenceTime(nameSpace);
+            t = IssueStorage.getInstance().getReferenceTime(nameSpace);
         } catch (IOException ex) {
-            referenceTime = System.currentTimeMillis(); // fallback
             LOG.log(Level.SEVERE, null, ex);
         }
+        this.referenceTime = t;
 
         BugtrackingManager.getInstance().getRequestProcessor().post(new 
Runnable() {
             @Override
@@ -238,29 +226,11 @@
         assert issueData != null;
         assert issue != null;
 
-        String id;
-//        if(issueProvider.isNew(issue)) {
-            id = issueAccessor.getID(issueData);
-//        } else {
-//            id = issue.getID();
-//        }
+        String id = issueAccessor.getID(issueData);
         assert id != null && !id.equals("");
         setIssueData(id, issue, issueData);
     }
 
-    String getRecentChanges(String id) {
-        IssueEntry entry;
-        synchronized(CACHE_LOCK) {
-            entry = getCache().get(id);
-            if(entry == null) {
-                assert !SwingUtilities.isEventDispatchThread();
-                entry = createNewEntry(id);
-                readIssue(entry);
-            }
-            return getIssueAccessor().getRecentChanges(entry.issue);
-        }
-    }
-
     private I setIssueData(String id, I issue, D issueData) throws 
IOException {
         assert issueData != null;
 
@@ -300,7 +270,7 @@
                 if(entry.wasSeen()) {
                     LOG.log(Level.FINE, " issue {0} was seen", new Object[] 
{id}); // NOI18N
                     long lastModified = 
issueAccessor.getLastModified(entry.issue);
-                    if(isChanged(entry.seenAttributes, 
issueAccessor.getAttributes(entry.issue)) || entry.lastSeenModified < 
lastModified) {
+                    if(entry.lastSeenModified < lastModified) {
                         LOG.log(Level.FINE, " issue {0} is changed", new 
Object[] {id}); // NOI18N
                         if(entry.lastSeenModified >= lastModified) {
                             LOG.log(Level.WARNING, " issue '{'0'}' changed, 
yet last known modify > last modify. [{0},{1}]", new 
Object[]{entry.lastSeenModified, lastModified}); // NOI18N
@@ -314,8 +284,7 @@
                     }
                 } else {
                     LOG.log(Level.FINE, " issue {0} wasn't seen yet", new 
Object[] {id}); // NOI18N
-                    if(isChanged(entry.seenAttributes, 
issueAccessor.getAttributes(entry.issue)) ||
-                       referenceTime < 
issueAccessor.getLastModified(entry.issue))
+                    if(referenceTime < 
issueAccessor.getLastModified(entry.issue))
                     {
                         LOG.log(Level.FINE, " issue {0} is changed", new 
Object[] {id}); // NOI18N
                         entry.seen = false;
@@ -451,7 +420,7 @@
     }
 
     /**
-     * Stres the given id-s for a query
+     * Stores the given id-s for a query
      * @param name query name
      * @param ids id-s
      */
@@ -495,7 +464,7 @@
      * Stores the given id-s as archived
      *
      * @param name query name
-     * @param ids isues id-s
+     * @param ids issues id-s
      */
     public void storeArchivedQueryIssues(String name, String[] ids) {
         synchronized(CACHE_LOCK) {
@@ -527,7 +496,7 @@
 
     /**
      *
-     * Removes all data assotiated with a query from the storage.
+     * Removes all data associated with a query from the storage.
      *
      * @param name query name
      */
@@ -553,10 +522,6 @@
         }
     }
     
-    private Issue getIssue(I issue) {
-        return repository.getIssue(issue).getIssue();
-    }
-    
     private IssueEntry createNewEntry(String id) {
         IssueEntry entry = new IssueEntry();
         entry.id = id;
@@ -591,20 +556,6 @@
         IssueStorage.getInstance().storeIssue(nameSpace, entry);
     }
 
-    private boolean isChanged(Map<String, String> oldAttr, Map<String, 
String> newAttr) {
-        if(oldAttr == null) {
-            return false; // can't be changed if it wasn't seen yet
-        }
-        for (Entry<String, String> e : oldAttr.entrySet()) {
-            String newValue = newAttr.get(e.getKey());
-            String oldValue = e.getValue();
-            if(newValue == null && oldValue == null) {
-                continue;
-            }
-        }
-        return false;
-    }
-
     class IssueEntry {
         private I issue;
         private Map<String, String> seenAttributes;
diff --git 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueSettingsStorage.java
 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueSettingsStorage.java
--- 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueSettingsStorage.java
+++ 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueSettingsStorage.java
@@ -53,8 +53,6 @@
 import java.util.Set;
 import java.util.logging.Level;
 import org.netbeans.modules.bugtracking.BugtrackingManager;
-import 
org.netbeans.modules.bugtracking.ui.issue.cache.StorageUtils.FileLocks;
-import 
org.netbeans.modules.bugtracking.ui.issue.cache.StorageUtils.FileLocks.FileLock;
 import org.openide.modules.Places;
 
 /**
@@ -88,7 +86,7 @@
 
     public Collection<Long> loadCollapsedCommenst(String repoUrl, String id) 
{
         File file = getIssuePropertiesFile(repoUrl, id);
-        FileLock l = FileLocks.getLock(file);
+        StorageUtils.FileLocks.FileLock l = 
StorageUtils.FileLocks.getLock(file);
         try {
             Properties p = load(file, repoUrl, id);
             Set<Long> s = new HashSet<Long>();
@@ -124,7 +122,7 @@
     
     public void storeCollapsedComments(Collection<Long> collapsedComments, 
String repoUrl, String id) {
         File file = getIssuePropertiesFile(repoUrl, id);
-        FileLock l = FileLocks.getLock(file);
+        StorageUtils.FileLocks.FileLock l = 
StorageUtils.FileLocks.getLock(file);
         try {
             Properties p = load(file, repoUrl, id);
             clear(p, PROP_COLLAPSED_COMMENT_PREFIX);
diff --git 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueStorage.java
 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueStorage.java
--- 
a/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueStorage.java
+++ 
b/bugtracking/src/org/netbeans/modules/bugtracking/ui/issue/cache/IssueStorage.java
@@ -70,10 +70,7 @@
 import javax.swing.SwingUtilities;
 import org.netbeans.modules.bugtracking.BugtrackingConfig;
 import org.netbeans.modules.bugtracking.BugtrackingManager;
-import org.netbeans.modules.bugtracking.ui.issue.cache.IssueCache.IssueEntry;
 import org.openide.util.RequestProcessor.Task;
-import 
org.netbeans.modules.bugtracking.ui.issue.cache.StorageUtils.FileLocks.FileLock;
-import 
org.netbeans.modules.bugtracking.ui.issue.cache.StorageUtils.FileLocks;
 import org.openide.modules.Places;
 
 /**
@@ -83,26 +80,16 @@
 class IssueStorage {
 
     private static IssueStorage instance;
-    private File storage;
+    private final File storage;
     private static final String STORAGE_FILE  = "storage";              // 
NOI18N
     private static final String STORAGE_VERSION_1_0 = "1.0";            // 
NOI18N
     private static final String STORAGE_VERSION_1_1 = "1.1";            // 
NOI18N
     private static final String STORAGE_VERSION = STORAGE_VERSION_1_1;  // 
NOI18N
-    private String QUERY_ARCHIVED_SUFIX = ".qa";                        // 
NOI18N
-    private String QUERY_SUFIX = ".q";                                  // 
NOI18N
-    private String ISSUE_SUFIX = ".i";                                  // 
NOI18N
+    private final static String QUERY_ARCHIVED_SUFIX = ".qa";           // 
NOI18N
+    private final static String QUERY_SUFIX = ".q";                     // 
NOI18N
+    private final static String ISSUE_SUFIX = ".i";                     // 
NOI18N
 
-    private IssueStorage() { }
-
-    public static IssueStorage getInstance() {
-        if(instance == null) {
-            instance = new IssueStorage();
-            instance.initStorage();
-        }
-        return instance;
-    }
-
-    private void initStorage() {
+    private IssueStorage() { 
         storage = getStorageRootFile();
         if(!storage.exists()) {
             storage.mkdirs();
@@ -117,11 +104,18 @@
         t.schedule(0);
     }
 
+    public static IssueStorage getInstance() {
+        if(instance == null) {
+            instance = new IssueStorage();
+        }
+        return instance;
+    }
+
     long getReferenceTime(String nameSpace) throws IOException {
         File folder = StorageUtils.getNameSpaceFolder(storage, nameSpace);
         File data = new File(folder, "data");                                
   // NOI18N
         
-        FileLock lock = FileLocks.getLock(data);
+        StorageUtils.FileLocks.FileLock lock = 
StorageUtils.FileLocks.getLock(data);
         try {
             synchronized(lock) {
                 final File parentFile = data.getParentFile();
@@ -176,15 +170,15 @@
         }
     }
 
-    void storeIssue(String nameSpace, IssueEntry entry) throws IOException {
+    void storeIssue(String nameSpace, IssueCache.IssueEntry entry) throws 
IOException {
         assert !SwingUtilities.isEventDispatchThread() : "should not access 
the issue storage in awt"; // NOI18N
         BugtrackingManager.LOG.log(Level.FINE, "start storing issue {0} - 
{1}", new Object[] {nameSpace, entry.getId()}); // NOI18N
         InputStream is = null;
         DataOutputStream dos = null;
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         try {
             File issueFile = 
getIssueFile(StorageUtils.getNameSpaceFolder(storage, nameSpace), 
entry.getId());
-            lock = FileLocks.getLock(issueFile);
+            lock = StorageUtils.FileLocks.getLock(issueFile);
             synchronized(lock) {
                 dos = getIssueOutputStream(issueFile);
                 if(dos == null) {
@@ -214,14 +208,14 @@
         }
     }
 
-    void readIssue(String nameSpace, IssueEntry entry) throws IOException {
+    void readIssue(String nameSpace, IssueCache.IssueEntry entry) throws 
IOException {
         assert !SwingUtilities.isEventDispatchThread() : "should not access 
the issue storage in awt"; // NOI18N
         BugtrackingManager.LOG.log(Level.FINE, "start reading issue {0} - 
{1}", new Object[] {nameSpace, entry.getId()}); // NOI18N
         DataInputStream is = null;
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         try {
             File issueFile = 
getIssueFile(StorageUtils.getNameSpaceFolder(storage, nameSpace), 
entry.getId());
-            lock = FileLocks.getLock(issueFile);
+            lock = StorageUtils.FileLocks.getLock(issueFile);
             synchronized(lock) {
                 is = getIssueInputStream(issueFile);
                 if(is == null) {
@@ -266,13 +260,13 @@
         BugtrackingManager.LOG.log(Level.FINE, "start reading query {0} - 
{1}", new Object[] {nameSpace, queryName}); // NOI18N
 
         DataInputStream dis = null;
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         try {
             File folder = StorageUtils.getNameSpaceFolder(storage, 
nameSpace);
             if(!folder.exists()) return Collections.emptyList();
 
             File f = getQueryFile(folder, queryName, false);
-            lock = FileLocks.getLock(f);
+            lock = StorageUtils.FileLocks.getLock(f);
             synchronized(lock) {
                 dis = StorageUtils.getQueryInputStream(f);
                 return readQuery(dis);
@@ -316,14 +310,14 @@
         long now = System.currentTimeMillis();
         long ttl = BugtrackingConfig.getInstance().getArchivedIssuesTTL() * 
1000 * 60 * 60 * 24;
 
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         DataInputStream dis = null;
         try {
             File folder = StorageUtils.getNameSpaceFolder(storage, 
nameSpace);
             if(!folder.exists()) return Collections.emptyMap();
 
             File f = getQueryFile(folder, queryName, true);
-            lock = FileLocks.getLock(f);
+            lock = StorageUtils.FileLocks.getLock(f);
             synchronized(lock) {
                 dis = StorageUtils.getQueryInputStream(f);
                 if(dis == null) return Collections.emptyMap();
@@ -369,11 +363,11 @@
         assert !SwingUtilities.isEventDispatchThread() : "should not access 
the issue storage in awt"; // NOI18N
         BugtrackingManager.LOG.log(Level.FINE, "start removing query {0} - 
{1}", new Object[] {nameSpace, queryName}); // NOI18N
         try {
-            FileLock lock;
+            StorageUtils.FileLocks.FileLock lock;
             File folder = StorageUtils.getNameSpaceFolder(storage, 
nameSpace);
             File query = getQueryFile(folder, queryName, false);
             if(query.exists()) {
-                lock = FileLocks.getLock(query);
+                lock = StorageUtils.FileLocks.getLock(query);
                 try {
                     synchronized(lock) {
                         BugtrackingUtil.deleteRecursively(query);
@@ -385,7 +379,7 @@
             lock = null;
             File queryArchived = getQueryFile(folder, queryName, true);
             if(queryArchived.exists()) {
-                lock = FileLocks.getLock(queryArchived);
+                lock = StorageUtils.FileLocks.getLock(queryArchived);
                 try {
                     synchronized(lock) {
                         BugtrackingUtil.deleteRecursively(queryArchived);
@@ -402,12 +396,12 @@
     void storeQuery(String nameSpace, String queryName, String[] ids) throws 
IOException {
         assert !SwingUtilities.isEventDispatchThread() : "should not access 
the issue storage in awt"; // NOI18N
         BugtrackingManager.LOG.log(Level.FINE, "start storing query issues 
{0} - {1}", new Object[] {nameSpace, queryName}); // NOI18N
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         DataOutputStream dos = null;
         try {
             File folder = StorageUtils.getNameSpaceFolder(storage, 
nameSpace);
             File f = getQueryFile(folder, queryName, false);
-            lock = FileLocks.getLock(f);
+            lock = StorageUtils.FileLocks.getLock(f);
             synchronized(lock) {
                 dos = StorageUtils.getQueryOutputStream(f);
                 for (String id : ids) {
@@ -433,11 +427,11 @@
         long now = System.currentTimeMillis();
         Map<String, Long> archived = readArchivedQueryIssues(nameSpace, 
queryName);
         DataOutputStream dos = null;
-        FileLock lock = null;
+        StorageUtils.FileLocks.FileLock lock = null;
         try {
             File folder = StorageUtils.getNameSpaceFolder(storage, 
nameSpace);
             File f = getQueryFile(folder, queryName, true);
-            lock = FileLocks.getLock(f);
+            lock = StorageUtils.FileLocks.getLock(f);
             synchronized(lock) {
                 dos = StorageUtils.getQueryOutputStream(f);
                 for (String id : ids) {
@@ -501,7 +495,7 @@
             });
             if(queries != null && queries.length > 0) {
                 for (File lq : queries) {
-                    FileLock lock = FileLocks.getLock(lq);
+                    StorageUtils.FileLocks.FileLock lock = 
StorageUtils.FileLocks.getLock(lq);
                     List<String> ids;
                     try {
                         synchronized(lock) {
@@ -525,7 +519,7 @@
             if(queries != null) {
                 for (File lq : queries) {
                     Map<String, Long> ids;
-                    FileLock lock = FileLocks.getLock(lq);
+                    StorageUtils.FileLocks.FileLock lock = 
StorageUtils.FileLocks.getLock(lq);
                     try {
                         synchronized(lock) {
                             ids = 
readArchivedQueryIssues(StorageUtils.getDataInputStream(lq));
@@ -548,7 +542,7 @@
             });
             if(issues != null) {
                 for (File issue : issues) {
-                    FileLock lock = FileLocks.getLock(issue);
+                    StorageUtils.FileLocks.FileLock lock = 
StorageUtils.FileLocks.getLock(issue);
                     try {
                         String id = issue.getName();
                         id = id.substring(0, id.length() - 
ISSUE_SUFIX.length());
diff --git 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/issuetable/QueryTableCellRendererTest.java
 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/issuetable/QueryTableCellRendererTest.java
--- 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/issuetable/QueryTableCellRendererTest.java
+++ 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/issuetable/QueryTableCellRendererTest.java
@@ -522,10 +522,6 @@
                         throw new UnsupportedOperationException("Not 
supported yet.");
                     }
                     @Override
-                    public String getRecentChanges(TestIssue issue) {
-                        return ((RendererIssue) issue).getRecentChanges();
-                    }
-                    @Override
                     public long getLastModified(TestIssue issue) {
                         throw new UnsupportedOperationException("Not 
supported yet.");
                     }
@@ -536,7 +532,7 @@
                 };
                 TestIssueProvider issueProvider = new TestIssueProvider();
                 RepositoryImpl repo = TestKit.getRepository(this);
-                cache = new IssueCache<TestIssue, Object>("test", 
issueAccessor, issueProvider, repo.getRepository());
+                cache = new IssueCache<TestIssue, Object>("test", 
issueAccessor);
             }
             return cache;
         }
diff --git 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/CacheTest.java
 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/CacheTest.java
--- 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/CacheTest.java
+++ 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/CacheTest.java
@@ -496,10 +496,6 @@
                             return ((CTestIssue)issue).getAttributes();
                         }
                         @Override
-                        public String getRecentChanges(CTestIssue issue) {
-                            throw new UnsupportedOperationException("Not 
supported yet.");
-                        }
-                        @Override
                         public long getLastModified(CTestIssue issue) {
                             return 
Long.parseLong(((CTestIssue)issue).dataArray[3]);
                         }
@@ -507,9 +503,7 @@
                         public long getCreated(CTestIssue issue) {
                             return 
Long.parseLong(((CTestIssue)issue).dataArray[2]);
                         }
-                    },
-                    new CTestIssueProvider(), 
-                    repository.getRepository());
+                    });
             }
             
             protected void cleanup() {
diff --git 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/StorageTest.java
 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/StorageTest.java
--- 
a/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/StorageTest.java
+++ 
b/bugtracking/test/unit/src/org/netbeans/modules/bugtracking/ui/issue/cache/StorageTest.java
@@ -382,11 +382,6 @@
             }
 
             @Override
-            public String getRecentChanges(Object issue) {
-                throw new UnsupportedOperationException("Not supported 
yet.");
-            }
-
-            @Override
             public long getLastModified(Object issue) {
                 throw new UnsupportedOperationException("Not supported 
yet.");
             }
@@ -397,6 +392,6 @@
             }
         };
         RepositoryImpl impl = TestKit.getRepository(new 
DummyRepository(DummyBugtrackingConnector.instance, "dummy"));
-        return new IssueCache<DummyIssue, Object>("dummy", ia, null, 
impl.getRepository());
+        return new IssueCache<DummyIssue, Object>("dummy", ia);
     }
 }
diff --git a/bugzilla/nbproject/project.xml b/bugzilla/nbproject/project.xml
--- a/bugzilla/nbproject/project.xml
+++ b/bugzilla/nbproject/project.xml
@@ -91,7 +91,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>1.47</specification-version>
+                        <specification-version>1.48</specification-version>
                     </run-dependency>
                 </dependency>
                 <dependency>
diff --git 
a/bugzilla/src/org/netbeans/modules/bugzilla/repository/BugzillaRepository.java
 
b/bugzilla/src/org/netbeans/modules/bugzilla/repository/BugzillaRepository.java
--- 
a/bugzilla/src/org/netbeans/modules/bugzilla/repository/BugzillaRepository.java
+++ 
b/bugzilla/src/org/netbeans/modules/bugzilla/repository/BugzillaRepository.java
@@ -782,11 +782,7 @@
 
     private class Cache extends IssueCache<BugzillaIssue, TaskData> {
         Cache() {
-            super(
-                BugzillaRepository.this.getUrl(), 
-                new IssueAccessorImpl(), 
-                Bugzilla.getInstance().getIssueProvider(), 
-                BugzillaUtil.getRepository(BugzillaRepository.this));
+            super(BugzillaRepository.this.getUrl(), new IssueAccessorImpl());
         }
     }
 
@@ -803,11 +799,6 @@
             ((BugzillaIssue)issue).setTaskData(taskData);
         }
         @Override
-        public String getRecentChanges(BugzillaIssue issue) {
-            assert issue != null;
-            return ((BugzillaIssue)issue).getRecentChanges();
-        }
-        @Override
         public long getLastModified(BugzillaIssue issue) {
             assert issue != null;
             return ((BugzillaIssue)issue).getLastModify();
diff --git a/jira/nbproject/project.xml b/jira/nbproject/project.xml
--- a/jira/nbproject/project.xml
+++ b/jira/nbproject/project.xml
@@ -93,7 +93,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>1.47</specification-version>
+                        <specification-version>1.48</specification-version>
                     </run-dependency>
                 </dependency>
                 <dependency>
diff --git 
a/jira/src/org/netbeans/modules/jira/repository/JiraRepository.java 
b/jira/src/org/netbeans/modules/jira/repository/JiraRepository.java
--- a/jira/src/org/netbeans/modules/jira/repository/JiraRepository.java
+++ b/jira/src/org/netbeans/modules/jira/repository/JiraRepository.java
@@ -711,11 +711,7 @@
 
     private class Cache extends IssueCache<NbJiraIssue, TaskData> {
         Cache() {
-            super(
-                JiraRepository.this.getUrl(), 
-                new IssueAccessorImpl(),
-                Jira.getInstance().getIssueProvider(),
-                JiraUtils.getRepository(JiraRepository.this));
+            super(JiraRepository.this.getUrl(), new IssueAccessorImpl());
         }
     }
     private class IssueAccessorImpl implements 
IssueCache.IssueAccessor<NbJiraIssue, TaskData> {
@@ -731,11 +727,6 @@
             ((NbJiraIssue)issue).setTaskData(taskData);
         }
         @Override
-        public String getRecentChanges(NbJiraIssue issue) {
-            assert issue != null;
-            return ((NbJiraIssue)issue).getRecentChanges();
-        }
-        @Override
         public long getLastModified(NbJiraIssue issue) {
             assert issue != null;
             return ((NbJiraIssue)issue).getLastModify();

[hg] main-silver: removed obsolete fields and methods in issue c...

Tomas Stupka 04/04/2013

Project Features

About this Project

ConnectedDeveloper was started in November 2009, is owned by tpavek, and has 65 members.
By use of this website, you agree to the NetBeans Policies and Terms of Use (revision 20131025.e7cbc9d). © 2013, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo
 
 
Close
loading
Please Confirm
Close